Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(252)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1213623022: fix up test create functions (Closed)

Created:
5 years, 5 months ago by joshua.litt
Modified:
5 years, 5 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1

Patch Set 2 : comment updated #

Total comments: 4

Patch Set 3 : tweaks #

Patch Set 4 : tweaks #

Patch Set 5 : more cleanup #

Unified diffs Side-by-side diffs Delta from patch set Stats (+440 lines, -631 lines) Patch
M include/gpu/GrProcessorUnitTest.h View 1 2 3 4 5 chunks +39 lines, -43 lines 0 comments Download
M src/effects/SkAlphaThresholdFilter.cpp View 1 2 3 1 chunk +7 lines, -11 lines 0 comments Download
M src/effects/SkArithmeticMode_gpu.cpp View 3 2 chunks +15 lines, -22 lines 0 comments Download
M src/effects/SkBlurMaskFilter.cpp View 2 chunks +11 lines, -17 lines 0 comments Download
M src/effects/SkColorFilters.cpp View 3 1 chunk +6 lines, -9 lines 0 comments Download
M src/effects/SkColorMatrixFilter.cpp View 3 1 chunk +2 lines, -5 lines 0 comments Download
M src/effects/SkDisplacementMapEffect.cpp View 3 1 chunk +14 lines, -18 lines 0 comments Download
M src/effects/SkLightingImageFilter.cpp View 2 chunks +15 lines, -21 lines 0 comments Download
M src/effects/SkMagnifierImageFilter.cpp View 3 1 chunk +7 lines, -10 lines 0 comments Download
M src/effects/SkMorphologyImageFilter.cpp View 1 chunk +6 lines, -9 lines 0 comments Download
M src/effects/SkPerlinNoiseShader.cpp View 3 2 chunks +14 lines, -16 lines 0 comments Download
M src/effects/SkTableColorFilter.cpp View 3 2 chunks +4 lines, -8 lines 0 comments Download
M src/effects/gradients/SkLinearGradient.cpp View 3 1 chunk +7 lines, -11 lines 0 comments Download
M src/effects/gradients/SkRadialGradient.cpp View 3 1 chunk +7 lines, -11 lines 0 comments Download
M src/effects/gradients/SkSweepGradient.cpp View 3 1 chunk +6 lines, -10 lines 0 comments Download
M src/effects/gradients/SkTwoPointConicalGradient_gpu.cpp View 3 13 chunks +43 lines, -61 lines 0 comments Download
M src/gpu/GrAAConvexPathRenderer.cpp View 1 chunk +5 lines, -8 lines 0 comments Download
M src/gpu/GrDefaultGeoProcFactory.cpp View 1 chunk +10 lines, -13 lines 0 comments Download
M src/gpu/GrOvalRenderer.cpp View 3 chunks +15 lines, -24 lines 0 comments Download
M src/gpu/effects/GrBezierEffect.cpp View 3 chunks +20 lines, -27 lines 0 comments Download
M src/gpu/effects/GrBicubicEffect.cpp View 1 chunk +5 lines, -8 lines 0 comments Download
M src/gpu/effects/GrBitmapTextGeoProc.cpp View 2 chunks +10 lines, -14 lines 0 comments Download
M src/gpu/effects/GrConfigConversionEffect.cpp View 1 chunk +5 lines, -8 lines 0 comments Download
M src/gpu/effects/GrConstColorProcessor.cpp View 2 chunks +8 lines, -11 lines 0 comments Download
M src/gpu/effects/GrConvexPolyEffect.cpp View 2 chunks +11 lines, -17 lines 0 comments Download
M src/gpu/effects/GrConvolutionEffect.cpp View 1 chunk +9 lines, -12 lines 0 comments Download
M src/gpu/effects/GrCoverageSetOpXP.cpp View 1 chunk +3 lines, -6 lines 0 comments Download
M src/gpu/effects/GrCustomXfermode.cpp View 3 2 chunks +8 lines, -14 lines 0 comments Download
M src/gpu/effects/GrDashingEffect.cpp View 2 chunks +10 lines, -15 lines 0 comments Download
M src/gpu/effects/GrDisableColorXP.cpp View 1 chunk +1 line, -4 lines 0 comments Download
M src/gpu/effects/GrDistanceFieldGeoProc.cpp View 3 chunks +36 lines, -45 lines 0 comments Download
M src/gpu/effects/GrDitherEffect.cpp View 1 chunk +1 line, -4 lines 0 comments Download
M src/gpu/effects/GrMatrixConvolutionEffect.cpp View 1 chunk +18 lines, -20 lines 0 comments Download
M src/gpu/effects/GrOvalEffect.cpp View 2 chunks +11 lines, -17 lines 0 comments Download
M src/gpu/effects/GrPorterDuffXferProcessor.cpp View 1 chunk +2 lines, -5 lines 0 comments Download
M src/gpu/effects/GrRRectEffect.cpp View 3 chunks +15 lines, -20 lines 0 comments Download
M src/gpu/effects/GrSimpleTextureEffect.cpp View 1 chunk +10 lines, -13 lines 0 comments Download
M src/gpu/effects/GrTextureDomain.cpp View 1 chunk +12 lines, -15 lines 0 comments Download
M tests/GLProgramsTest.cpp View 1 2 3 3 chunks +12 lines, -29 lines 0 comments Download

Messages

Total messages: 18 (8 generated)
joshualitt
ptal
5 years, 5 months ago (2015-07-08 19:42:52 UTC) #2
bsalomon
https://codereview.chromium.org/1213623022/diff/1/include/gpu/GrProcessorUnitTest.h File include/gpu/GrProcessorUnitTest.h (right): https://codereview.chromium.org/1213623022/diff/1/include/gpu/GrProcessorUnitTest.h#newcode34 include/gpu/GrProcessorUnitTest.h:34: * GrProcessorTestData is an argument struct to TestCreate functions ...
5 years, 5 months ago (2015-07-08 19:46:35 UTC) #3
joshualitt
On 2015/07/08 19:46:35, bsalomon wrote: > https://codereview.chromium.org/1213623022/diff/1/include/gpu/GrProcessorUnitTest.h > File include/gpu/GrProcessorUnitTest.h (right): > > https://codereview.chromium.org/1213623022/diff/1/include/gpu/GrProcessorUnitTest.h#newcode34 > ...
5 years, 5 months ago (2015-07-08 19:50:41 UTC) #4
robertphillips
lgtm + nits https://codereview.chromium.org/1213623022/diff/20001/include/gpu/GrProcessorUnitTest.h File include/gpu/GrProcessorUnitTest.h (right): https://codereview.chromium.org/1213623022/diff/20001/include/gpu/GrProcessorUnitTest.h#newcode54 include/gpu/GrProcessorUnitTest.h:54: const GrCaps* fCaps; GrTexture* fTextures[2]; ? ...
5 years, 5 months ago (2015-07-08 20:51:32 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1213623022/60001
5 years, 5 months ago (2015-07-08 21:03:23 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: Build-Ubuntu-GCC-Arm64-Debug-Android-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-Arm64-Debug-Android-Trybot/builds/240) Build-Ubuntu-GCC-Mips-Debug-Android-Trybot on client.skia.compile (JOB_FAILED, ...
5 years, 5 months ago (2015-07-08 21:04:14 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1213623022/80001
5 years, 5 months ago (2015-07-08 21:11:26 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: skia_presubmit-Trybot on client.skia.fyi (JOB_FAILED, http://build.chromium.org/p/client.skia.fyi/builders/skia_presubmit-Trybot/builds/958)
5 years, 5 months ago (2015-07-08 21:13:00 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1213623022/80001
5 years, 5 months ago (2015-07-08 21:15:25 UTC) #17
commit-bot: I haz the power
5 years, 5 months ago (2015-07-08 21:26:26 UTC) #18
Message was sent while issue was closed. 
Committed patchset #5 (id:80001) as
https://skia.googlesource.com/skia/+/0067ff5e0f85084dd2b5ad9886b526482b89a116

Powered by Google App Engine
This is Rietveld 408576698