Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(740)

Issue 1213553004: MIPS: Disassembler enhancement. Disassembled branch instruction displays branch target absolute add… (Closed)

Created:
5 years, 5 months ago by Ilija.Pavlovic1
Modified:
5 years, 5 months ago
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

MIPS: Disassembler enhancement. Disassembled branch instruction displays branch target absolute address. TEST=cctest/test-disasm-mips[64] BUG= Committed: https://crrev.com/75e671759187b438113569d7f15eb9803b5652a3 Cr-Commit-Position: refs/heads/master@{#29462}

Patch Set 1 #

Patch Set 2 : Corrections for calculations of the branch target addresses. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+921 lines, -227 lines) Patch
M src/mips/disasm-mips.cc View 1 14 chunks +177 lines, -67 lines 0 comments Download
M src/mips64/disasm-mips64.cc View 1 14 chunks +187 lines, -71 lines 0 comments Download
M test/cctest/test-disasm-mips.cc View 1 2 chunks +272 lines, -42 lines 0 comments Download
M test/cctest/test-disasm-mips64.cc View 1 4 chunks +285 lines, -47 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
Ilija.Pavlovic1
5 years, 5 months ago (2015-06-30 12:16:31 UTC) #2
paul.l...
The printed branch offset is off by one instruction. See more details/explanation in the related ...
5 years, 5 months ago (2015-07-01 03:07:18 UTC) #3
paul.l...
Patchset 2 LGTM.
5 years, 5 months ago (2015-07-01 19:30:30 UTC) #4
dusmil.imgtec
LGTM.
5 years, 5 months ago (2015-07-02 12:36:16 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1213553004/20001
5 years, 5 months ago (2015-07-03 08:18:26 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 5 months ago (2015-07-03 10:32:00 UTC) #8
commit-bot: I haz the power
5 years, 5 months ago (2015-07-03 10:32:12 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/75e671759187b438113569d7f15eb9803b5652a3
Cr-Commit-Position: refs/heads/master@{#29462}

Powered by Google App Engine
This is Rietveld 408576698