[analyzer] fix NodeReplacer for YieldStatement

pkg/analyzer/lib/src/generated/ast.dart

Index: pkg/analyzer/lib/src/generated/ast.dart
diff --git a/pkg/analyzer/lib/src/generated/ast.dart b/pkg/analyzer/lib/src/generated/ast.dart
index e6d8100701398f5ba38095b459ece547c8250b73..7a4be39cfc21472f77a205d734a42ed790c4e20b 100644
--- a/pkg/analyzer/lib/src/generated/ast.dart
+++ b/pkg/analyzer/lib/src/generated/ast.dart
@@ -13492,6 +13492,7 @@ class NodeReplacer implements AstVisitor<bool> {
   bool visitYieldStatement(YieldStatement node) {
     if (identical(node.expression, _oldNode)) {
       node.expression = _newNode as Expression;
+      return true;

[Jennifer Messerly, 2015/06/25 17:38:19]

the other visit methods "return" after successful replace.
visitNode always throws:

throw new IllegalArgumentException(
        "The old node is not a child of it's parent");

     }
     return visitNode(node);
   }