[analyzer] fix NodeReplacer for YieldStatement

pkg/analyzer/lib/src/generated/ast.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 // This code was auto-generated, is not intended to be edited, and is subject to
 // significant change. Please see the README file for more information.
 
 library engine.ast;
 
 import 'dart:collection';
@@ skipping 13474 matching lines @@
     if (_replaceInList(node.mixinTypes)) {
       return true;
     }
     return visitNode(node);
   }
 
   @override
   bool visitYieldStatement(YieldStatement node) {
     if (identical(node.expression, _oldNode)) {
       node.expression = _newNode as Expression;
+      return true;

[Jennifer Messerly, 2015/06/25 17:38:19]

the other visit methods "return" after successful replace.
visitNode always throws:

throw new IllegalArgumentException(
        "The old node is not a child of it's parent");

     }
     return visitNode(node);
   }
 
   bool _replaceInList(NodeList list) {
     int count = list.length;
     for (int i = 0; i < count; i++) {
       if (identical(_oldNode, list[i])) {
         list[i] = _newNode;
         return true;
@@ skipping 6551 matching lines @@
   }
 
   @override
   accept(AstVisitor visitor) => visitor.visitYieldStatement(this);
 
   @override
   void visitChildren(AstVisitor visitor) {
     _safelyVisitChild(_expression, visitor);
   }
 }