Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(381)

Unified Diff: Source/web/WebSharedWorkerImpl.cpp

Issue 1213443006: Invoke WorkerScriptLoader's m_finishedCallback callback safely. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: review #7 and notify* Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/web/WebEmbeddedWorkerImpl.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/web/WebSharedWorkerImpl.cpp
diff --git a/Source/web/WebSharedWorkerImpl.cpp b/Source/web/WebSharedWorkerImpl.cpp
index 4481e1766bc38fa667a305f91cd7ceae84576926..6507cdeb987faf68d6915569f0d2f3badd693a5f 100644
--- a/Source/web/WebSharedWorkerImpl.cpp
+++ b/Source/web/WebSharedWorkerImpl.cpp
@@ -200,6 +200,8 @@ void WebSharedWorkerImpl::didFinishDocumentLoad(WebLocalFrame* frame)
DenyCrossOriginRequests,
bind(&WebSharedWorkerImpl::didReceiveScriptLoaderResponse, this),
bind(&WebSharedWorkerImpl::onScriptLoaderFinished, this));
+ // Do nothing here since onScriptLoaderFinished() might have been already
+ // invoked and |this| might have been deleted at this point.
}
bool WebSharedWorkerImpl::isControlledByServiceWorker(WebDataSource& dataSource)
« no previous file with comments | « Source/web/WebEmbeddedWorkerImpl.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698