Source/web/WebEmbeddedWorkerImpl.cpp - Issue 1213443006: Invoke WorkerScriptLoader's m_finishedCallback callback safely.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/web/WebEmbeddedWorkerImpl.cpp

Issue 1213443006: Invoke WorkerScriptLoader's m_finishedCallback callback safely. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: review #7 and notify* Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/web/WebEmbeddedWorkerImpl.cpp

diff --git a/Source/web/WebEmbeddedWorkerImpl.cpp b/Source/web/WebEmbeddedWorkerImpl.cpp

index 73afc3dc1c0687fdf5afb65d462d9a382b895b09..723d803b2557689d95b216d40e34355e322ef6b3 100644

--- a/Source/web/WebEmbeddedWorkerImpl.cpp

+++ b/Source/web/WebEmbeddedWorkerImpl.cpp

@@ -305,6 +305,8 @@ void WebEmbeddedWorkerImpl::didFinishDocumentLoad(WebLocalFrame* frame)

DenyCrossOriginRequests,

nullptr,

bind(&WebEmbeddedWorkerImpl::onScriptLoaderFinished, this));

+ // Do nothing here since onScriptLoaderFinished() might have been already

+ // invoked and |this| might have been deleted at this point.

}

void WebEmbeddedWorkerImpl::sendProtocolMessage(int callId, const WebString& message, const WebString& state)

« no previous file with comments | « Source/core/workers/WorkerScriptLoader.cpp ('k') | Source/web/WebSharedWorkerImpl.cpp » ('j') | no next file with comments »