Source/web/WebSharedWorkerImpl.cpp - Issue 1213443006: Invoke WorkerScriptLoader's m_finishedCallback callback safely.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/web/WebSharedWorkerImpl.cpp

Issue 1213443006: Invoke WorkerScriptLoader's m_finishedCallback callback safely. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: review #3 Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/web/WebSharedWorkerImpl.cpp

diff --git a/Source/web/WebSharedWorkerImpl.cpp b/Source/web/WebSharedWorkerImpl.cpp

index 4481e1766bc38fa667a305f91cd7ceae84576926..3e3518603002ab852a32f1f90a3828c0ca375b82 100644

--- a/Source/web/WebSharedWorkerImpl.cpp

+++ b/Source/web/WebSharedWorkerImpl.cpp

@@ -200,6 +200,8 @@ void WebSharedWorkerImpl::didFinishDocumentLoad(WebLocalFrame* frame)

DenyCrossOriginRequests,

bind(&WebSharedWorkerImpl::didReceiveScriptLoaderResponse, this),

bind(&WebSharedWorkerImpl::onScriptLoaderFinished, this));

+ // Do nothing here since onScriptLoaderFinished() might be already invoked

haraken 2015/07/02 06:18:06 might be => might have been

Takashi Toyoshima 2015/07/02 07:33:56 Done.

+ // and |this| might have been deleted at this point.

}

bool WebSharedWorkerImpl::isControlledByServiceWorker(WebDataSource& dataSource)