Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(871)

Unified Diff: Source/web/WebEmbeddedWorkerImpl.cpp

Issue 1213443006: Invoke WorkerScriptLoader's m_finishedCallback callback safely. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: review #3 Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/web/WebEmbeddedWorkerImpl.cpp
diff --git a/Source/web/WebEmbeddedWorkerImpl.cpp b/Source/web/WebEmbeddedWorkerImpl.cpp
index 73afc3dc1c0687fdf5afb65d462d9a382b895b09..7f7125d2ec3c4d8a0081deeeb927fccbcdabc146 100644
--- a/Source/web/WebEmbeddedWorkerImpl.cpp
+++ b/Source/web/WebEmbeddedWorkerImpl.cpp
@@ -305,6 +305,8 @@ void WebEmbeddedWorkerImpl::didFinishDocumentLoad(WebLocalFrame* frame)
DenyCrossOriginRequests,
nullptr,
bind(&WebEmbeddedWorkerImpl::onScriptLoaderFinished, this));
+ // Do nothing here since onScriptLoaderFinished() might be already invoked
haraken 2015/07/02 06:18:06 might be => might have been
Takashi Toyoshima 2015/07/02 07:33:56 Oops, tense is so important here.
+ // and |this| might have been deleted at this point.
}
void WebEmbeddedWorkerImpl::sendProtocolMessage(int callId, const WebString& message, const WebString& state)

Powered by Google App Engine
This is Rietveld 408576698