Issue 1213313002: Don't crash when decoding an invalid handle

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1213313002: Don't crash when decoding an invalid handle (Closed)

Created:
5 years, 5 months ago by abarth-chromium

Modified:
5 years, 5 months ago

Reviewers:
jackson_old, jackson

CC:
mojo-reviews_chromium.org, qsr+mojo_chromium.org, gregsimon, jackson_old

Base URL:
git@github.com:domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

Don't crash when decoding an invalid handle We shouldn't try to drain a data pipe when we have an invalid handle. Instead, we should just call the callback with |null|, like we do for decoding failures. R=jackson@google.com, jackson@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/f2c35368f92dfe2314dbd161f8ece22d4f6aecb4

Created: 5 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+22 lines, -5 lines)			Patch
	M	sky/engine/core/loader/CanvasImageDecoder.h	View		2 chunks	+5 lines, -0 lines	0 comments	Download
	M	sky/engine/core/loader/CanvasImageDecoder.cpp	View		3 chunks	+17 lines, -5 lines	0 comments	Download

Total messages: 4 (1 generated)

abarth-chromium

5 years, 5 months ago (2015-06-29 21:07:11 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
f2c35368f92dfe2314dbd161f8ece22d4f6aecb4 (presubmit successful).