Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(978)

Unified Diff: sky/engine/core/loader/CanvasImageDecoder.h

Issue 1213313002: Don't crash when decoding an invalid handle (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | sky/engine/core/loader/CanvasImageDecoder.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/engine/core/loader/CanvasImageDecoder.h
diff --git a/sky/engine/core/loader/CanvasImageDecoder.h b/sky/engine/core/loader/CanvasImageDecoder.h
index f0686ae9c10dcac1277b3c0b9aa70a177ce16658..8d545dbbc6f8bf9a132a2b49aa4603e150f185d4 100644
--- a/sky/engine/core/loader/CanvasImageDecoder.h
+++ b/sky/engine/core/loader/CanvasImageDecoder.h
@@ -6,6 +6,7 @@
#ifndef SKY_ENGINE_CORE_LOADER_CANVASIMAGELOADER_H_
#define SKY_ENGINE_CORE_LOADER_CANVASIMAGELOADER_H_
+#include "base/memory/weak_ptr.h"
#include "mojo/common/data_pipe_drainer.h"
#include "sky/engine/core/loader/ImageDecoderCallback.h"
#include "sky/engine/platform/SharedBuffer.h"
@@ -30,9 +31,13 @@ class CanvasImageDecoder : public mojo::common::DataPipeDrainer::Client,
private:
CanvasImageDecoder(mojo::ScopedDataPipeConsumerHandle handle, PassOwnPtr<ImageDecoderCallback> callback);
+ void RejectCallback();
+
OwnPtr<mojo::common::DataPipeDrainer> drainer_;
RefPtr<SharedBuffer> buffer_;
OwnPtr<ImageDecoderCallback> callback_;
+
+ base::WeakPtrFactory<CanvasImageDecoder> weak_factory_;
};
} // namespace blink
« no previous file with comments | « no previous file | sky/engine/core/loader/CanvasImageDecoder.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698