Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(563)

Issue 1213233011: Benchmark to test cost for additional vertex attributes (Closed)

Created:
5 years, 5 months ago by joshua.litt
Modified:
5 years, 5 months ago
Reviewers:
joshualitt, bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Benchmark to test cost for additional vertex attributes BUG=skia: Committed: https://skia.googlesource.com/skia/+/f06c389f0fe07ce06acd8568d508d6413b8d3728

Patch Set 1 #

Total comments: 1

Patch Set 2 : stream #

Patch Set 3 : windows warnings #

Patch Set 4 : windows warning #

Patch Set 5 : tweaks #

Unified diffs Side-by-side diffs Delta from patch set Stats (+429 lines, -0 lines) Patch
A bench/GLVertexAttributesBench.cpp View 1 2 3 1 chunk +429 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
joshualitt
ptal, I can move some of the common functions into a utility library after this ...
5 years, 5 months ago (2015-06-30 19:11:48 UTC) #2
bsalomon
lgtm https://codereview.chromium.org/1213233011/diff/1/bench/GLVertexAttributesBench.cpp File bench/GLVertexAttributesBench.cpp (right): https://codereview.chromium.org/1213233011/diff/1/bench/GLVertexAttributesBench.cpp#newcode396 bench/GLVertexAttributesBench.cpp:396: GR_GL_STATIC_DRAW)); I think we typically use DYNAMIC or ...
5 years, 5 months ago (2015-06-30 19:37:15 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1213233011/20001
5 years, 5 months ago (2015-06-30 20:27:31 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: Build-Win-MSVC-x86_64-Debug-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Win-MSVC-x86_64-Debug-Trybot/builds/1841)
5 years, 5 months ago (2015-06-30 20:30:43 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1213233011/80001
5 years, 5 months ago (2015-07-01 13:13:01 UTC) #11
commit-bot: I haz the power
5 years, 5 months ago (2015-07-01 13:20:17 UTC) #12
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as
https://skia.googlesource.com/skia/+/f06c389f0fe07ce06acd8568d508d6413b8d3728

Powered by Google App Engine
This is Rietveld 408576698