Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(730)

Unified Diff: test/cctest/test-debug.cc

Issue 1213203007: Create a internal, global native context used only for generated code stubs (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Review feedback Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: test/cctest/test-debug.cc
diff --git a/test/cctest/test-debug.cc b/test/cctest/test-debug.cc
index a6ffdca179767b44424d1a3604acbf2020b8c5c0..c247f9a3b5c1c6e9e92addc81ff2c0acb99ec613 100644
--- a/test/cctest/test-debug.cc
+++ b/test/cctest/test-debug.cc
@@ -7341,15 +7341,15 @@ static void NopListener(const v8::Debug::EventDetails& event_details) {
TEST(DebuggerCreatesContextIffActive) {
DebugLocalContext env;
v8::HandleScope scope(env->GetIsolate());
- CHECK_EQ(1, CountNativeContexts());
+ CHECK_EQ(2, CountNativeContexts());
Michael Starzinger 2015/07/10 13:26:30 Same comment as in test-api.cc applies for CountNa
danno 2015/07/13 09:43:37 Done.
v8::Debug::SetDebugEventListener(NULL);
CompileRun("debugger;");
- CHECK_EQ(1, CountNativeContexts());
+ CHECK_EQ(2, CountNativeContexts());
v8::Debug::SetDebugEventListener(NopListener);
CompileRun("debugger;");
- CHECK_EQ(2, CountNativeContexts());
+ CHECK_EQ(3, CountNativeContexts());
v8::Debug::SetDebugEventListener(NULL);
}

Powered by Google App Engine
This is Rietveld 408576698