Create a internal, global native context used only for generated code stubs

test/cctest/test-api.cc

Index: test/cctest/test-api.cc
diff --git a/test/cctest/test-api.cc b/test/cctest/test-api.cc
index 2bfdeabd42cd606a40e8242d120465dc0414a0ab..95253ae011b82f261262600a192f431d55b2ab6f 100644
--- a/test/cctest/test-api.cc
+++ b/test/cctest/test-api.cc
@@ -11691,21 +11691,21 @@ TEST(DontLeakGlobalObjects) {
       LocalContext context;
     }
     CcTest::isolate()->ContextDisposedNotification();
-    CheckSurvivingGlobalObjectsCount(0);
+    CheckSurvivingGlobalObjectsCount(1);

[Michael Starzinger, 2015/07/10 13:26:30]

Can we move this off-by-one into the GetGlobalObjectsCount() helper, together
with a comment explaining why we are always seeing one global object too many?

[danno, 2015/07/13 09:43:37]

Done

 
     { v8::HandleScope scope(CcTest::isolate());
       LocalContext context;
       v8_compile("Date")->Run();
     }
     CcTest::isolate()->ContextDisposedNotification();
-    CheckSurvivingGlobalObjectsCount(0);
+    CheckSurvivingGlobalObjectsCount(1);
 
     { v8::HandleScope scope(CcTest::isolate());
       LocalContext context;
       v8_compile("/aaa/")->Run();
     }
     CcTest::isolate()->ContextDisposedNotification();
-    CheckSurvivingGlobalObjectsCount(0);
+    CheckSurvivingGlobalObjectsCount(1);
 
     { v8::HandleScope scope(CcTest::isolate());
       const char* extension_list[] = { "v8/gc" };
@@ -11714,7 +11714,7 @@ TEST(DontLeakGlobalObjects) {
       v8_compile("gc();")->Run();
     }
     CcTest::isolate()->ContextDisposedNotification();
-    CheckSurvivingGlobalObjectsCount(0);
+    CheckSurvivingGlobalObjectsCount(1);
   }
 }
 
@@ -15863,10 +15863,10 @@ TEST(Regress528) {
     CompileRun(source_simple);
     other_context->Exit();
     CcTest::heap()->CollectAllGarbage();
-    if (GetGlobalObjectsCount() == 1) break;
+    if (GetGlobalObjectsCount() == 2) break;
   }
   CHECK_GE(2, gc_count);
-  CHECK_EQ(1, GetGlobalObjectsCount());
+  CHECK_EQ(2, GetGlobalObjectsCount());
 
   // Eval in a function creates reference from the compilation cache to the
   // global object.
@@ -15885,10 +15885,11 @@ TEST(Regress528) {
     CompileRun(source_eval);
     other_context->Exit();
     CcTest::heap()->CollectAllGarbage();
-    if (GetGlobalObjectsCount() == 1) break;
+    printf("D: %d\n", GetGlobalObjectsCount());
+    if (GetGlobalObjectsCount() == 2) break;
   }
   CHECK_GE(2, gc_count);
-  CHECK_EQ(1, GetGlobalObjectsCount());
+  CHECK_EQ(2, GetGlobalObjectsCount());
 
   // Looking up the line number for an exception creates reference from the
   // compilation cache to the global object.
@@ -15912,10 +15913,10 @@ TEST(Regress528) {
     CompileRun(source_exception);
     other_context->Exit();
     CcTest::heap()->CollectAllGarbage();
-    if (GetGlobalObjectsCount() == 1) break;
+    if (GetGlobalObjectsCount() == 2) break;
   }
   CHECK_GE(2, gc_count);
-  CHECK_EQ(1, GetGlobalObjectsCount());
+  CHECK_EQ(2, GetGlobalObjectsCount());
 
   isolate->ContextDisposedNotification();
 }