Create a internal, global native context used only for generated code stubs

test/cctest/test-api.cc

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 11673 matching lines @@
   // Regression test for issues 1139850 and 1174891.
 
   i::FLAG_expose_gc = true;
   v8::V8::Initialize();
 
   for (int i = 0; i < 5; i++) {
     { v8::HandleScope scope(CcTest::isolate());
       LocalContext context;
     }
     CcTest::isolate()->ContextDisposedNotification();
-    CheckSurvivingGlobalObjectsCount(0);
+    CheckSurvivingGlobalObjectsCount(1);

[Michael Starzinger, 2015/07/10 13:26:30]

Can we move this off-by-one into the GetGlobalObjectsCount() helper, together
with a comment explaining why we are always seeing one global object too many?

[danno, 2015/07/13 09:43:37]

Done

 
     { v8::HandleScope scope(CcTest::isolate());
       LocalContext context;
       v8_compile("Date")->Run();
     }
     CcTest::isolate()->ContextDisposedNotification();
-    CheckSurvivingGlobalObjectsCount(0);
+    CheckSurvivingGlobalObjectsCount(1);
 
     { v8::HandleScope scope(CcTest::isolate());
       LocalContext context;
       v8_compile("/aaa/")->Run();
     }
     CcTest::isolate()->ContextDisposedNotification();
-    CheckSurvivingGlobalObjectsCount(0);
+    CheckSurvivingGlobalObjectsCount(1);
 
     { v8::HandleScope scope(CcTest::isolate());
       const char* extension_list[] = { "v8/gc" };
       v8::ExtensionConfiguration extensions(1, extension_list);
       LocalContext context(&extensions);
       v8_compile("gc();")->Run();
     }
     CcTest::isolate()->ContextDisposedNotification();
-    CheckSurvivingGlobalObjectsCount(0);
+    CheckSurvivingGlobalObjectsCount(1);
   }
 }
 
 
 TEST(CopyablePersistent) {
   LocalContext context;
   v8::Isolate* isolate = context->GetIsolate();
   i::GlobalHandles* globals =
       reinterpret_cast<i::Isolate*>(isolate)->global_handles();
   int initial_handles = globals->global_handles_count();
@@ skipping 4128 matching lines @@
     context->SetEmbedderData(0, obj);
     CompileRun(source_simple);
     context->Exit();
   }
   isolate->ContextDisposedNotification();
   for (gc_count = 1; gc_count < 10; gc_count++) {
     other_context->Enter();
     CompileRun(source_simple);
     other_context->Exit();
     CcTest::heap()->CollectAllGarbage();
-    if (GetGlobalObjectsCount() == 1) break;
+    if (GetGlobalObjectsCount() == 2) break;
   }
   CHECK_GE(2, gc_count);
-  CHECK_EQ(1, GetGlobalObjectsCount());
+  CHECK_EQ(2, GetGlobalObjectsCount());
 
   // Eval in a function creates reference from the compilation cache to the
   // global object.
   const char* source_eval = "function f(){eval('1')}; f()";
   {
     v8::HandleScope scope(isolate);
     v8::Local<Context> context = Context::New(isolate);
 
     context->Enter();
     CompileRun(source_eval);
     context->Exit();
   }
   isolate->ContextDisposedNotification();
   for (gc_count = 1; gc_count < 10; gc_count++) {
     other_context->Enter();
     CompileRun(source_eval);
     other_context->Exit();
     CcTest::heap()->CollectAllGarbage();
-    if (GetGlobalObjectsCount() == 1) break;
+    printf("D: %d\n", GetGlobalObjectsCount());
+    if (GetGlobalObjectsCount() == 2) break;
   }
   CHECK_GE(2, gc_count);
-  CHECK_EQ(1, GetGlobalObjectsCount());
+  CHECK_EQ(2, GetGlobalObjectsCount());
 
   // Looking up the line number for an exception creates reference from the
   // compilation cache to the global object.
   const char* source_exception = "function f(){throw 1;} f()";
   {
     v8::HandleScope scope(isolate);
     v8::Local<Context> context = Context::New(isolate);
 
     context->Enter();
     v8::TryCatch try_catch(isolate);
     CompileRun(source_exception);
     CHECK(try_catch.HasCaught());
     v8::Handle<v8::Message> message = try_catch.Message();
     CHECK(!message.IsEmpty());
     CHECK_EQ(1, message->GetLineNumber());
     context->Exit();
   }
   isolate->ContextDisposedNotification();
   for (gc_count = 1; gc_count < 10; gc_count++) {
     other_context->Enter();
     CompileRun(source_exception);
     other_context->Exit();
     CcTest::heap()->CollectAllGarbage();
-    if (GetGlobalObjectsCount() == 1) break;
+    if (GetGlobalObjectsCount() == 2) break;
   }
   CHECK_GE(2, gc_count);
-  CHECK_EQ(1, GetGlobalObjectsCount());
+  CHECK_EQ(2, GetGlobalObjectsCount());
 
   isolate->ContextDisposedNotification();
 }
 
 
 THREADED_TEST(ScriptOrigin) {
   LocalContext env;
   v8::HandleScope scope(env->GetIsolate());
   v8::ScriptOrigin origin = v8::ScriptOrigin(
       v8::String::NewFromUtf8(env->GetIsolate(), "test"),
@@ skipping 5919 matching lines @@
       "    fake.age;\n"
       "    result = 1;\n"
       "  } catch (e) {\n"
       "  }\n"
       "  test(d+1);\n"
       "}\n"
       "test(0);\n"
       "result;\n",
       0);
 }