Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1436)

Unified Diff: Source/modules/accessibility/AXNodeObject.cpp

Issue 1213203002: Move AXObjectCache::remove so it is after ContainerNode::detach Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/modules/accessibility/AXMenuListPopup.cpp ('k') | Source/modules/accessibility/AXSVGRoot.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/modules/accessibility/AXNodeObject.cpp
diff --git a/Source/modules/accessibility/AXNodeObject.cpp b/Source/modules/accessibility/AXNodeObject.cpp
index ae9eba66488eff179659eb9ce08639418b902f4d..aa07f6cc1a203bcd90ddb3ee9a82529018e55cb9 100644
--- a/Source/modules/accessibility/AXNodeObject.cpp
+++ b/Source/modules/accessibility/AXNodeObject.cpp
@@ -1922,6 +1922,7 @@ static Node* getParentNodeForComputeParent(Node* node)
AXObject* AXNodeObject::computeParent() const
{
+ ASSERT(!isDetached());
if (Node* parentNode = getParentNodeForComputeParent(node()))
return axObjectCache().getOrCreate(parentNode);
@@ -1963,6 +1964,7 @@ AXObject* AXNodeObject::nextSibling() const
void AXNodeObject::addChildren()
{
+ ASSERT(!isDetached());
// If the need to add more children in addition to existing children arises,
// childrenChanged should have been called, leaving the object with no children.
ASSERT(!m_haveChildren);
« no previous file with comments | « Source/modules/accessibility/AXMenuListPopup.cpp ('k') | Source/modules/accessibility/AXSVGRoot.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698