Source/modules/accessibility/AXMenuListPopup.cpp - Issue 1213203002: Move AXObjectCache::remove so it is after ContainerNode::detach

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/accessibility/AXMenuListPopup.cpp

Issue 1213203002: Move AXObjectCache::remove so it is after ContainerNode::detach Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/modules/accessibility/AXMenuListPopup.cpp

diff --git a/Source/modules/accessibility/AXMenuListPopup.cpp b/Source/modules/accessibility/AXMenuListPopup.cpp

index ffbab4a16a53e8536e240e28e275c59f24050b1e..a1c9ae079d06981c83871e25920cc47ae88a004c 100644

--- a/Source/modules/accessibility/AXMenuListPopup.cpp

+++ b/Source/modules/accessibility/AXMenuListPopup.cpp

@@ -102,6 +102,7 @@ bool AXMenuListPopup::press() const

void AXMenuListPopup::addChildren()

{

+ ASSERT(!isDetached());

if (!m_parent)

return;

« no previous file with comments | « Source/modules/accessibility/AXMenuList.cpp ('k') | Source/modules/accessibility/AXNodeObject.cpp » ('j') | no next file with comments »