content/browser/renderer_host/render_process_host_impl.cc - Issue 1213193003: Remove DCHECK_IMPLIES and CHECK_IMPLIES

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/render_process_host_impl.cc

Issue 1213193003: Remove DCHECK_IMPLIES and CHECK_IMPLIES (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/renderer_host/render_process_host_impl.cc

diff --git a/content/browser/renderer_host/render_process_host_impl.cc b/content/browser/renderer_host/render_process_host_impl.cc

index 537f713a83131cb9a3f7d21ff140294c1a2e6619..2ef01b50812ac57f6daa3c2e1701b1c59d65f430 100644

--- a/content/browser/renderer_host/render_process_host_impl.cc

+++ b/content/browser/renderer_host/render_process_host_impl.cc

@@ -1121,8 +1121,7 @@ static void AppendCompositorCommandLineFlags(base::CommandLine* command_line) {

base::IntToString(msaa_sample_count));

}

- DCHECK_IMPLIES(IsZeroCopyUploadEnabled(), !IsOneCopyUploadEnabled());

- DCHECK_IMPLIES(IsOneCopyUploadEnabled(), !IsZeroCopyUploadEnabled());

+ DCHECK(!IsZeroCopyUploadEnabled() || !IsOneCopyUploadEnabled());

if (IsZeroCopyUploadEnabled())

command_line->AppendSwitch(switches::kEnableZeroCopy);

if (!IsOneCopyUploadEnabled())