Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issue 1213113002: Added default value for the quiet parameter (Closed)

Created:
5 years, 5 months ago by Sergiy Byelozyorov
Modified:
5 years, 5 months ago
Reviewers:
pgervais
CC:
chromium-reviews, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Added default value for the quiet parameter The activate_end method is used in infra/bootstrap/build_deps.py, which doesn't pass the value for this parameter. R=pgervais@chromium.org BUG=503067 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=295893

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M bootstrap/bootstrap.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (1 generated)
Sergiy Byelozyorov
5 years, 5 months ago (2015-06-29 09:09:20 UTC) #1
pgervais
On 2015/06/29 09:09:20, Sergiy Byelozyorov wrote: lgtm
5 years, 5 months ago (2015-06-29 16:10:48 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1213113002/1
5 years, 5 months ago (2015-07-01 08:40:14 UTC) #4
commit-bot: I haz the power
5 years, 5 months ago (2015-07-01 08:41:57 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=295893

Powered by Google App Engine
This is Rietveld 408576698