runtime/vm/object.cc - Issue 1213013002: Update Assembler::TryAllocate to support inline allocation tracing

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/object.cc

Issue 1213013002: Update Assembler::TryAllocate to support inline allocation tracing (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/vm/object.cc

diff --git a/runtime/vm/object.cc b/runtime/vm/object.cc

index 79689346507076d9ad80316a2a4888335a6b6dd2..d9631aa18e6d69b1b79ca90dbdad3b658f49f055 100644

--- a/runtime/vm/object.cc

+++ b/runtime/vm/object.cc

@@ -2736,6 +2736,9 @@ void Class::SetTraceAllocation(bool trace_allocation) const {

set_state_bits(

TraceAllocationBit::update(trace_allocation, raw_ptr()->state_bits_));

Ivan Posva 2015/07/16 11:34:47 Why is this not under "if (changed)"?

Cutch 2015/07/16 14:34:07 My bad- https://codereview.chromium.org/1234943004

if (changed) {

+ Isolate* isolate = Isolate::Current();

+ ClassTable* class_table = isolate->class_table();

+ class_table->TraceAllocationsFor(id(), trace_allocation);

DisableAllocationStub();

}

« runtime/vm/class_table.h ('K') | « runtime/vm/class_table.cc ('k') | no next file » | no next file with comments »