Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Side by Side Diff: runtime/vm/object.cc

Issue 1213013002: Update Assembler::TryAllocate to support inline allocation tracing (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« runtime/vm/class_table.h ('K') | « runtime/vm/class_table.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/object.h" 5 #include "vm/object.h"
6 6
7 #include "include/dart_api.h" 7 #include "include/dart_api.h"
8 #include "platform/assert.h" 8 #include "platform/assert.h"
9 #include "vm/assembler.h" 9 #include "vm/assembler.h"
10 #include "vm/cpu.h" 10 #include "vm/cpu.h"
(...skipping 2716 matching lines...) Expand 10 before | Expand all | Expand 10 after
2727 2727
2728 void Class::DisableCHAOptimizedCode() { 2728 void Class::DisableCHAOptimizedCode() {
2729 CHACodeArray a(*this); 2729 CHACodeArray a(*this);
2730 a.DisableCode(); 2730 a.DisableCode();
2731 } 2731 }
2732 2732
2733 2733
2734 void Class::SetTraceAllocation(bool trace_allocation) const { 2734 void Class::SetTraceAllocation(bool trace_allocation) const {
2735 const bool changed = trace_allocation != this->trace_allocation(); 2735 const bool changed = trace_allocation != this->trace_allocation();
2736 set_state_bits( 2736 set_state_bits(
2737 TraceAllocationBit::update(trace_allocation, raw_ptr()->state_bits_)); 2737 TraceAllocationBit::update(trace_allocation, raw_ptr()->state_bits_));
Ivan Posva 2015/07/16 11:34:47 Why is this not under "if (changed)"?
Cutch 2015/07/16 14:34:07 My bad- https://codereview.chromium.org/1234943004
2738 if (changed) { 2738 if (changed) {
2739 Isolate* isolate = Isolate::Current();
2740 ClassTable* class_table = isolate->class_table();
2741 class_table->TraceAllocationsFor(id(), trace_allocation);
2739 DisableAllocationStub(); 2742 DisableAllocationStub();
2740 } 2743 }
2741 } 2744 }
2742 2745
2743 2746
2744 void Class::set_cha_codes(const Array& cache) const { 2747 void Class::set_cha_codes(const Array& cache) const {
2745 StorePointer(&raw_ptr()->cha_codes_, cache.raw()); 2748 StorePointer(&raw_ptr()->cha_codes_, cache.raw());
2746 } 2749 }
2747 2750
2748 2751
(...skipping 18425 matching lines...) Expand 10 before | Expand all | Expand 10 after
21174 return tag_label.ToCString(); 21177 return tag_label.ToCString();
21175 } 21178 }
21176 21179
21177 21180
21178 void UserTag::PrintJSONImpl(JSONStream* stream, bool ref) const { 21181 void UserTag::PrintJSONImpl(JSONStream* stream, bool ref) const {
21179 Instance::PrintJSONImpl(stream, ref); 21182 Instance::PrintJSONImpl(stream, ref);
21180 } 21183 }
21181 21184
21182 21185
21183 } // namespace dart 21186 } // namespace dart
OLDNEW
« runtime/vm/class_table.h ('K') | « runtime/vm/class_table.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698