Source/core/css/parser/CSSParserFastPaths.cpp - Issue 1212893005: Add position: sticky as supported position value when CSSStickyPosition is enabled.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/css/parser/CSSParserFastPaths.cpp

Issue 1212893005: Add position: sticky as supported position value when CSSStickyPosition is enabled. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« LayoutTests/fast/css/sticky/sticky-stacking-context.html ('K') | « Source/core/css/CSSValueKeywords.in ('k') | Source/core/layout/LayoutBlock.cpp » ('j') | Source/core/layout/LayoutObject.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/css/parser/CSSParserFastPaths.cpp

diff --git a/Source/core/css/parser/CSSParserFastPaths.cpp b/Source/core/css/parser/CSSParserFastPaths.cpp

index 5acbbab07b0db11e5b05c88526471319eb90af19..bdc2191cb6506950a91536323e9a2c6fab36d7ee 100644

--- a/Source/core/css/parser/CSSParserFastPaths.cpp

+++ b/Source/core/css/parser/CSSParserFastPaths.cpp

@@ -536,8 +536,8 @@ bool CSSParserFastPaths::isValidKeywordPropertyAndValue(CSSPropertyID propertyId

return valueID == CSSValueVisible || valueID == CSSValueNone || valueID == CSSValueAll || valueID == CSSValueAuto || (valueID >= CSSValueVisiblePainted && valueID <= CSSValueBoundingBox);

- case CSSPropertyPosition: // static | relative | absolute | fixed

- return valueID == CSSValueStatic || valueID == CSSValueRelative || valueID == CSSValueAbsolute || valueID == CSSValueFixed;

+ case CSSPropertyPosition: // static | relative | absolute | fixed | sticky

+ return valueID == CSSValueStatic || valueID == CSSValueRelative || valueID == CSSValueAbsolute || valueID == CSSValueFixed || (RuntimeEnabledFeatures::cssStickyPositionEnabled() && valueID == CSSValueSticky);

case CSSPropertyResize: // none | both | horizontal | vertical | auto

return valueID == CSSValueNone || valueID == CSSValueBoth || valueID == CSSValueHorizontal || valueID == CSSValueVertical || valueID == CSSValueAuto;

case CSSPropertyScrollBehavior: // auto | smooth