Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1385)

Unified Diff: Source/core/layout/LayoutObject.cpp

Issue 1212893005: Add position: sticky as supported position value when CSSStickyPosition is enabled. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/layout/LayoutObject.cpp
diff --git a/Source/core/layout/LayoutObject.cpp b/Source/core/layout/LayoutObject.cpp
index abd4d61201124cc82585b605cd753adc344d9950..ea75b689bfb73f6473bace0edddd142c0e530b6d 100644
--- a/Source/core/layout/LayoutObject.cpp
+++ b/Source/core/layout/LayoutObject.cpp
@@ -1080,7 +1080,9 @@ String LayoutObject::decoratedName() const
if (isOutOfFlowPositioned() && !isLayoutView())
name.append(" (positioned)");
if (isRelPositioned())
- name.append(" (relative positioned)");
+ name.append(" (relatively positioned)");
Ian Vollick 2015/06/30 17:56:32 We seem to report "relative positioned" in our out
flackr 2015/06/30 18:44:48 Oops, didn't mean to keep this change. Originally
+ if (isStickyPositioned())
+ name.append(" (sticky positioned)");
if (isFloating())
name.append(" (floating)");
if (spannerPlaceholder())
@@ -1961,7 +1963,7 @@ void LayoutObject::propagateStyleToAnonymousChildren(bool blockChildrenOnly)
// Preserve the position style of anonymous block continuations as they can have relative position when
// they contain block descendants of relative positioned inlines.
- if (child->isRelPositioned() && toLayoutBlock(child)->isAnonymousBlockContinuation())
+ if (child->isInFlowPositioned() && toLayoutBlock(child)->isAnonymousBlockContinuation())
newStyle->setPosition(child->style()->position());
updateAnonymousChildStyle(*child, *newStyle);

Powered by Google App Engine
This is Rietveld 408576698