Issue 1212833002: Revert of added stroking support to GrAALinearizingConvexPathRenderer

Issue 1212833002: Revert of added stroking support to GrAALinearizingConvexPathRenderer (Closed)

Created:
5 years, 6 months ago by reed2

Modified:
5 years, 6 months ago

Reviewers:
bsalomon, ethannicholas, robertphillips

CC:
reviews_skia.org, f(malita)

Base URL:
https://skia.googlesource.com/skia.git@master

Target Ref:
refs/heads/master

Project:
skia

Visibility:
Public.

More Reviews

Description

Revert of added stroking support to GrAALinearizingConvexPathRenderer (patchset #6 id:100001 of https://codereview.chromium.org/1180903006/) Reason for revert: speculative revert to try to fix DEPS roll (layouttests) Original issue's description: > added stroking support to GrAALinearizingConvexPathRenderer > > BUG=skia: > > Committed: https://skia.googlesource.com/skia/+/2436f191e6602953b32a51cf50f2d7a4e2af90fd TBR=bsalomon@google.com,robertphillips@google.com,ethannicholas@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Committed: https://skia.googlesource.com/skia/+/9730f4a663534009d216c2f6d834bd534dd44a3d

Patch Set 1 #

Created: 5 years, 6 months ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Stats (+358 lines, -419 lines)			Patch
M	src/core/SkPathPriv.h	View	1 chunk	+0 lines, -4 lines	0 comments	Download
M	src/gpu/GrAAConvexPathRenderer.cpp	View	1 chunk	+4 lines, -3 lines	0 comments	Download
M	src/gpu/GrAAConvexTessellator.h	View	9 chunks	+29 lines, -36 lines	0 comments	Download
M	src/gpu/GrAAConvexTessellator.cpp	View	34 chunks	+311 lines, -341 lines	0 comments	Download
M	src/gpu/GrAALinearizingConvexPathRenderer.cpp	View	9 chunks	+12 lines, -33 lines	0 comments	Download
M	src/gpu/GrAddPathRenderers_default.cpp	View	2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

reed2

Created Revert of added stroking support to GrAALinearizingConvexPathRenderer

5 years, 6 months ago (2015-06-26 12:06:24 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1212833002/1

5 years, 6 months ago (2015-06-26 12:06:37 UTC) #2

commit-bot: I haz the power

Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/9730f4a663534009d216c2f6d834bd534dd44a3d

5 years, 6 months ago (2015-06-26 12:06:47 UTC) #3

f(malita)

5 years, 6 months ago (2015-06-26 14:18:13 UTC) #4

Message was sent while issue was closed.

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1209003004/ by fmalita@chromium.org.

The reason for reverting is: Manual roll is in:
https://codereview.chromium.org/1212373002

Let's re-land this..

Expand Messages | Collapse Messages