Source/modules/serviceworkers/ServiceWorker.h - Issue 1212643004: [Oilpan] Apply RefCountedGarbageCollectedEventTarget on AbstractWorker

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/serviceworkers/ServiceWorker.h

Issue 1212643004: [Oilpan] Apply RefCountedGarbageCollectedEventTarget on AbstractWorker (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: add ASSERT Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/core/workers/WorkerMessagingProxy.cpp ('K') | « Source/core/workers/WorkerMessagingProxy.cpp ('k') | Source/modules/serviceworkers/ServiceWorker.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/modules/serviceworkers/ServiceWorker.h

diff --git a/Source/modules/serviceworkers/ServiceWorker.h b/Source/modules/serviceworkers/ServiceWorker.h

index e446045cf7a38881d5a2de1a823531e70ded6295..5915615d0d04fb4d8eb94ce15632a2a06456dbac 100644

--- a/Source/modules/serviceworkers/ServiceWorker.h

+++ b/Source/modules/serviceworkers/ServiceWorker.h

@@ -49,16 +49,15 @@ class ScriptPromiseResolver;

class MODULES_EXPORT ServiceWorker final : public AbstractWorker, public WebServiceWorkerProxy {

DEFINE_WRAPPERTYPEINFO();

public:

- static PassRefPtrWillBeRawPtr<ServiceWorker> from(ExecutionContext*, WebServiceWorker*);

+ static ServiceWorker* from(ExecutionContext*, WebServiceWorker*);

~ServiceWorker() override;

// Eager finalization needed to promptly release owned WebServiceWorker.

EAGERLY_FINALIZE();

-#if ENABLE(OILPAN)

// Override 'operator new' to enforce allocation of eagerly finalized object.

DECLARE_EAGER_FINALIZATION_OPERATOR_NEW();

-#endif

void postMessage(ExecutionContext*, PassRefPtr<SerializedScriptValue> message, const MessagePortArray*, ExceptionState&);

@@ -74,7 +73,7 @@ public:

void internalsTerminate();

private:

- static PassRefPtrWillBeRawPtr<ServiceWorker> getOrCreate(ExecutionContext*, WebServiceWorker*);

+ static ServiceWorker* getOrCreate(ExecutionContext*, WebServiceWorker*);

ServiceWorker(ExecutionContext*, PassOwnPtr<WebServiceWorker>);

// ActiveDOMObject overrides.