Source/core/workers/WorkerMessagingProxy.cpp - Issue 1212643004: [Oilpan] Apply RefCountedGarbageCollectedEventTarget on AbstractWorker

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/workers/WorkerMessagingProxy.cpp

Issue 1212643004: [Oilpan] Apply RefCountedGarbageCollectedEventTarget on AbstractWorker (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: add ASSERT Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/workers/WorkerMessagingProxy.cpp

diff --git a/Source/core/workers/WorkerMessagingProxy.cpp b/Source/core/workers/WorkerMessagingProxy.cpp

index 228b63f2c06ab3701369fcccec7e8befc0ea8e05..9f62b98f22d51e2877f99b6a5e5ff8f6bbd78bab 100644

--- a/Source/core/workers/WorkerMessagingProxy.cpp

+++ b/Source/core/workers/WorkerMessagingProxy.cpp

@@ -202,7 +202,7 @@ void WorkerMessagingProxy::workerThreadCreated(PassRefPtr<WorkerThread> workerTh

void WorkerMessagingProxy::workerObjectDestroyed()

{

- m_workerObject = nullptr;

+ ASSERT(!m_workerObject);

sof 2015/08/14 05:06:57 Spelling it out why it must be so would be a usefu

peria 2015/08/14 05:23:10 Done.

m_executionContext->postTask(FROM_HERE, createCrossThreadTask(&WorkerMessagingProxy::workerObjectDestroyedInternal, this));

}

« no previous file with comments | « Source/core/workers/WorkerMessagingProxy.h ('k') | Source/modules/serviceworkers/ServiceWorker.h » ('j') | no next file with comments »