Don't show any password manager icon when a user visits a blacklisted site.

Don't show any password manager icon when a user visits a blacklisted site.

BUG=497844
Committed: https://crrev.com/6627760f736316dcbc3b6d1ab815b6ffc6fc7d90
Cr-Commit-Position: refs/heads/master@{#336793}

[vasilii, 2015-06-29 13:06:24]

Patchset #1 (id:1) has been deleted

[vasilii, 2015-06-29 13:07:00]

vasilii@chromium.org changed reviewers:
+ vabr@chromium.org

[vasilii, 2015-06-29 13:07:00]

Hi Vaclav,

please review

[vasilii, 2015-06-29 16:41:15]

vasilii@chromium.org changed reviewers:
+ groby@chromium.org

[vasilii, 2015-06-29 16:41:16]

groby@chromium.org: Please review changes in 

manage_passwords_bubble_blacklist_view_controller_unittest.mm

[vasilii, 2015-06-30 09:02:28]

vasilii@chromium.org changed reviewers:
+ avi@chromium.org
- groby@chromium.org

[vasilii, 2015-06-30 09:02:29]

Hi Avi,

please review manage_passwords_bubble_blacklist_view_controller_unittest.mm

[vabr (Chromium), 2015-06-30 13:09:34]

Thanks, Vasilii, this LGTM. The new behaviour matches what I've heard from UI:
* Display the "blacklisted" icon immediately after the user chooses "never" in
the bubble,
* but do not display it on subsequent visits to pages with blacklisted
credentials.

Cheers,
Vaclav

https://codereview.chromium.org/1212633003/diff/80001/chrome/browser/ui/passw...
File chrome/browser/ui/passwords/manage_passwords_ui_controller_unittest.cc
(right):

https://codereview.chromium.org/1212633003/diff/80001/chrome/browser/ui/passw...
chrome/browser/ui/passwords/manage_passwords_ui_controller_unittest.cc:139:
password_manager::StubPasswordManagerClient* client() {
nit: Add a blank line above.

[vasilii, 2015-06-30 13:55:55]

https://codereview.chromium.org/1212633003/diff/80001/chrome/browser/ui/passw...
File chrome/browser/ui/passwords/manage_passwords_ui_controller_unittest.cc
(right):

https://codereview.chromium.org/1212633003/diff/80001/chrome/browser/ui/passw...
chrome/browser/ui/passwords/manage_passwords_ui_controller_unittest.cc:139:
password_manager::StubPasswordManagerClient* client() {
On 2015/06/30 13:09:34, vabr (OOO until 29 June) wrote:
> nit: Add a blank line above.

Done.

[Avi (use Gerrit), 2015-06-30 15:50:13]

lgtm

manage_passwords_bubble_blacklist_view_controller_unittest.mm stamp

[vasilii, 2015-06-30 16:03:04]

The CQ bit was checked by vasilii@chromium.org

[vasilii, 2015-06-30 16:03:05]

The patchset sent to the CQ was uploaded after l-g-t-m from vabr@chromium.org
Link to the patchset: https://codereview.chromium.org/1212633003/#ps100001
(title: "blank line")

[commit-bot: I haz the power, 2015-06-30 16:03:55]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1212633003/100001

[commit-bot: I haz the power, 2015-06-30 16:08:21]

Committed patchset #5 (id:100001)

[commit-bot: I haz the power, 2015-06-30 16:09:22]

Patchset 5 (id:??) landed as
https://crrev.com/6627760f736316dcbc3b6d1ab815b6ffc6fc7d90
Cr-Commit-Position: refs/heads/master@{#336793}