chrome/browser/ui/passwords/manage_passwords_state.cc - Issue 1212633003: Don't show any password manager icon when a user visits a blacklisted site.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/passwords/manage_passwords_state.cc

Issue 1212633003: Don't show any password manager icon when a user visits a blacklisted site. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: blank line Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/passwords/manage_passwords_state.h ('k') | chrome/browser/ui/passwords/manage_passwords_state_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/passwords/manage_passwords_state.cc

diff --git a/chrome/browser/ui/passwords/manage_passwords_state.cc b/chrome/browser/ui/passwords/manage_passwords_state.cc

index 0b4253fad50f2c1bea4f2882b72818cf06828555..1068733dc39d390b38cb5b12c580aef46bace1d1 100644

--- a/chrome/browser/ui/passwords/manage_passwords_state.cc

+++ b/chrome/browser/ui/passwords/manage_passwords_state.cc

@@ -174,16 +174,6 @@ void ManagePasswordsState::OnPasswordAutofilled(

}

-void ManagePasswordsState::OnBlacklistBlockedAutofill(

- const autofill::PasswordFormMap& password_form_map) {

- DCHECK(!password_form_map.empty());

- ClearData();

- local_credentials_forms_ = DeepCopyMapToVector(password_form_map);

- origin_ = local_credentials_forms_.front()->origin;

- DCHECK(local_credentials_forms_.front()->blacklisted_by_user);

- SetState(password_manager::ui::BLACKLIST_STATE);

void ManagePasswordsState::OnInactive() {

ClearData();

origin_ = GURL();