Issue 1212623002: Support snapshots in sky_shell (again)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1212623002: Support snapshots in sky_shell (again) (Closed)

Created:
5 years, 6 months ago by abarth-chromium

Modified:
5 years, 6 months ago

Reviewers:

CC:
Aaron Boodman, ben+mojo_chromium.org, darin (slow to review), gregsimon, jackson_old, mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org

Base URL:
git@github.com:domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

More Reviews

Description

Support snapshots in sky_shell (again) Unbreak support for snapshots now that we have our offline Dart loader. Also, wire up support for snapshots in sky_shell on Linux. TBR=eseidel@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/64423e0d771e1875979c41fbdce30a1d47d89b27

Patch Set 1 #

Created: 5 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+131 lines, -21 lines)			Patch
M	sky/engine/core/script/dart_controller.h	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	sky/engine/core/script/dart_controller.cc	View	1 chunk	+3 lines, -2 lines	0 comments	Download
M	sky/engine/public/sky/sky_view.cc	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	sky/services/viewport/viewport_observer.mojom	View	1 chunk	+1 line, -1 line	0 comments	Download
M	sky/shell/BUILD.gn	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	sky/shell/linux/main.cc	View	3 chunks	+46 lines, -5 lines	0 comments	Download
A	sky/shell/switches.h	View	1 chunk	+20 lines, -0 lines	0 comments	Download
A	sky/shell/switches.cc	View	1 chunk	+17 lines, -0 lines	0 comments	Download
M	sky/shell/ui/engine.h	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	sky/shell/ui/engine.cc	View	1 chunk	+6 lines, -2 lines	0 comments	Download
M	sky/tools/packager/loader.cc	View	1 chunk	+4 lines, -2 lines	0 comments	Download
M	sky/tools/packager/main.cc	View	3 chunks	+17 lines, -5 lines	0 comments	Download
M	sky/tools/packager/switches.h	View	1 chunk	+5 lines, -0 lines	0 comments	Download
M	sky/tools/packager/switches.cc	View	1 chunk	+5 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

abarth-chromium

5 years, 6 months ago (2015-06-26 00:10:41 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
64423e0d771e1875979c41fbdce30a1d47d89b27 (presubmit successful).

Expand Messages | Collapse Messages