sky/engine/public/sky/sky_view.cc - Issue 1212623002: Support snapshots in sky_shell (again)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sky/engine/public/sky/sky_view.cc

Issue 1212623002: Support snapshots in sky_shell (again) (Closed) Base URL: git@github.com:domokit/mojo.git@master

Patch Set: Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sky/engine/public/sky/sky_view.cc

diff --git a/sky/engine/public/sky/sky_view.cc b/sky/engine/public/sky/sky_view.cc

index b18677c65e437c8d0151571712d1fba794da721c..a761bbaf3063bbf38f144f3cafdd64595166253f 100644

--- a/sky/engine/public/sky/sky_view.cc

+++ b/sky/engine/public/sky/sky_view.cc

@@ -48,7 +48,8 @@ void SkyView::RunFromLibrary(const WebString& name,

void SkyView::RunFromSnapshot(const WebString& name,

mojo::ScopedDataPipeConsumerHandle snapshot) {

- // TODO(abarth): Implement.

+ CreateView(name);

+ dart_controller_->RunFromSnapshot(snapshot.Pass());

}

void SkyView::BeginFrame(base::TimeTicks frame_time) {