[destructuring] Re-index materialized literals in arrow function parameters.

[destructuring] Re-index materialized literals in arrow function parameters.

R=wingo@igalia.com
BUG=v8:811
LOG=N

Committed: https://crrev.com/b4f49586ab22aaea8e9a6a2de7e588dd449ab58b
Cr-Commit-Position: refs/heads/master@{#29337}

[Dmitry Lomov (no reviews), 2015-06-25 15:26:59]

PTAL.

[Dmitry Lomov (no reviews), 2015-06-25 15:27:06]

The CQ bit was checked by dslomov@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-06-25 15:27:16]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1212473002/1

[Dmitry Lomov (no reviews), 2015-06-25 15:29:25]

The CQ bit was checked by dslomov@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-06-25 15:29:38]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1212473002/20001

[commit-bot: I haz the power, 2015-06-25 15:39:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-06-25 15:39:32]

Dry run: Exceeded global retry quota

[Dmitry Lomov (no reviews), 2015-06-25 16:03:37]

Nevermind, will look into failures

[wingo, 2015-06-26 07:04:25]

I took a look yesterday and it looked fine to me, modulo the test failures of
course.  Am OoO today so if you want to land, please poke another reviewer. 
Cheers :)

[Dmitry Lomov (no reviews), 2015-06-26 14:46:24]

The CQ bit was checked by dslomov@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-06-26 14:46:37]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1212473002/40001

[Dmitry Lomov (no reviews), 2015-06-26 14:47:03]

dslomov@chromium.org changed reviewers:
+ adamk@chromium.org, arv@chromium.org

[Dmitry Lomov (no reviews), 2015-06-26 14:47:03]

Erik/Adam, mind taking a look?

[arv (Not doing code reviews), 2015-06-26 14:53:19]

On 2015/06/26 14:47:03, Dmitry S. Lomov wrote:
> Erik/Adam, mind taking a look?

Looking

[arv (Not doing code reviews), 2015-06-26 15:04:56]

LGTM

It would have been better if the methods ast-literal-reindexer.cc were in
alphabetical order but not a big deal.

[adamk, 2015-06-26 15:06:37]

Some drive-by nits if you want to upload one more patch before landing,
otherwise I defer to arv's review.

https://codereview.chromium.org/1212473002/diff/40001/src/ast-literal-reindex...
File src/ast-literal-reindexer.h (right):

https://codereview.chromium.org/1212473002/diff/40001/src/ast-literal-reindex...
src/ast-literal-reindexer.h:13: #include "src/prettyprinter.h"
I don't think you need this include, maybe you were using it for debugging?

https://codereview.chromium.org/1212473002/diff/40001/src/ast-literal-reindex...
src/ast-literal-reindexer.h:26: int next_index_;
Nit: member variables should come after methods.

[commit-bot: I haz the power, 2015-06-26 15:18:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-06-26 15:18:08]

Dry run: This issue passed the CQ dry run.

[Dmitry Lomov (no reviews), 2015-06-26 21:13:13]

Comments addressed, landing

https://codereview.chromium.org/1212473002/diff/40001/src/ast-literal-reindex...
File src/ast-literal-reindexer.h (right):

https://codereview.chromium.org/1212473002/diff/40001/src/ast-literal-reindex...
src/ast-literal-reindexer.h:13: #include "src/prettyprinter.h"
On 2015/06/26 15:06:37, adamk wrote:
> I don't think you need this include, maybe you were using it for debugging?

Done.

https://codereview.chromium.org/1212473002/diff/40001/src/ast-literal-reindex...
src/ast-literal-reindexer.h:26: int next_index_;
On 2015/06/26 15:06:37, adamk wrote:
> Nit: member variables should come after methods.

Done.

[Dmitry Lomov (no reviews), 2015-06-26 21:13:19]

The CQ bit was checked by dslomov@chromium.org

[Dmitry Lomov (no reviews), 2015-06-26 21:13:19]

The patchset sent to the CQ was uploaded after l-g-t-m from arv@chromium.org
Link to the patchset: https://codereview.chromium.org/1212473002/#ps60001
(title: "CR feedback")

[commit-bot: I haz the power, 2015-06-26 21:13:26]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1212473002/60001

[commit-bot: I haz the power, 2015-06-26 21:39:49]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-06-26 21:40:04]

Patchset 4 (id:??) landed as
https://crrev.com/b4f49586ab22aaea8e9a6a2de7e588dd449ab58b
Cr-Commit-Position: refs/heads/master@{#29337}