Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Unified Diff: src/preparser.h

Issue 1212473002: [destructuring] Re-index materialized literals in arrow function parameters. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: CR feedback Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/parser.cc ('k') | src/prettyprinter.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/preparser.h
diff --git a/src/preparser.h b/src/preparser.h
index c775fff86a286d6e16ed4543cf46dc4d22a6431e..231bbd82443c27ff78bf5f6b93829f458e55bfe7 100644
--- a/src/preparser.h
+++ b/src/preparser.h
@@ -179,6 +179,10 @@ class ParserBase : public Traits {
return next_materialized_literal_index_;
}
+ void SkipMaterializedLiterals(int count) {
+ next_materialized_literal_index_ += count;
+ }
+
void AddProperty() { expected_property_count_++; }
int expected_property_count() { return expected_property_count_; }
@@ -260,7 +264,10 @@ class ParserBase : public Traits {
expected_property_count_ = function_state_->expected_property_count_;
}
- void Restore() {
+ void Restore(int* materialized_literal_index_delta) {
+ *materialized_literal_index_delta =
+ function_state_->next_materialized_literal_index_ -
+ next_materialized_literal_index_;
function_state_->next_materialized_literal_index_ =
next_materialized_literal_index_;
function_state_->expected_property_count_ = expected_property_count_;
@@ -1273,10 +1280,14 @@ class PreParserFactory {
struct PreParserFormalParameterParsingState {
explicit PreParserFormalParameterParsingState(Scope* scope)
- : scope(scope), has_rest(false), is_simple_parameter_list(true) {}
+ : scope(scope),
+ has_rest(false),
+ is_simple_parameter_list(true),
+ materialized_literals_count(0) {}
Scope* scope;
bool has_rest;
bool is_simple_parameter_list;
+ int materialized_literals_count;
};
@@ -1564,6 +1575,9 @@ class PreParserTraits {
PreParserExpression expression, const Scanner::Location& params_loc,
Scanner::Location* duplicate_loc, bool* ok);
+ void ReindexLiterals(
+ const PreParserFormalParameterParsingState& parsing_state) {}
+
struct TemplateLiteralState {};
TemplateLiteralState OpenTemplateLiteral(int pos) {
@@ -2774,16 +2788,17 @@ ParserBase<Traits>::ParseAssignmentExpression(bool accept_IN,
accept_IN, &arrow_formals_classifier, CHECK_OK);
if (allow_harmony_arrow_functions() && peek() == Token::ARROW) {
- checkpoint.Restore();
BindingPatternUnexpectedToken(classifier);
ValidateArrowFormalParameters(&arrow_formals_classifier, expression,
parenthesized_formals, CHECK_OK);
Scanner::Location loc(lhs_location.beg_pos, scanner()->location().end_pos);
Scope* scope =
this->NewScope(scope_, ARROW_SCOPE, FunctionKind::kArrowFunction);
+ FormalParameterParsingStateT parsing_state(scope);
+ checkpoint.Restore(&parsing_state.materialized_literals_count);
+
scope->set_start_position(lhs_location.beg_pos);
Scanner::Location duplicate_loc = Scanner::Location::invalid();
- FormalParameterParsingStateT parsing_state(scope);
this->ParseArrowFunctionFormalParameters(&parsing_state, expression, loc,
&duplicate_loc, CHECK_OK);
if (duplicate_loc.IsValid()) {
@@ -3687,6 +3702,11 @@ ParserBase<Traits>::ParseArrowFunctionLiteral(
formal_parameters.scope, kArrowFunction,
&function_factory);
+ function_state.SkipMaterializedLiterals(
+ formal_parameters.materialized_literals_count);
+
+ this->ReindexLiterals(formal_parameters);
+
Expect(Token::ARROW, CHECK_OK);
if (peek() == Token::LBRACE) {
« no previous file with comments | « src/parser.cc ('k') | src/prettyprinter.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698