scripts/slave/recipe_modules/chromium/config.py - Issue 1212443005: reland #1: Set mac_min_sdk=10.10 on chromium.mac bots

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: scripts/slave/recipe_modules/chromium/config.py

Issue 1212443005: reland #1: Set mac_min_sdk=10.10 on chromium.mac bots (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master

Patch Set: Updated CL to prevent build configs from being used by testers. Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: scripts/slave/recipe_modules/chromium/config.py

diff --git a/scripts/slave/recipe_modules/chromium/config.py b/scripts/slave/recipe_modules/chromium/config.py

index 73113c331dd58ca7374f4734f18209fbb45e1e8c..b2d900c8699452dd674b53b288f8549714c0800b 100644

--- a/scripts/slave/recipe_modules/chromium/config.py

+++ b/scripts/slave/recipe_modules/chromium/config.py

@@ -787,7 +787,7 @@ def chromium_deterministic_build(c):

@config_ctx()

def chromium_mac_sdk_10_10(c):

- c.gyp_env.GYP_DEFINES['mac_sdk_min='] = '10.10'

+ c.gyp_env.GYP_DEFINES['mac_sdk_min'] = '10.10'

@config_ctx(includes=['chromium_clang'])

def cast_linux(c):

« no previous file with comments | « no previous file | scripts/slave/recipe_modules/chromium_tests/api.py » ('j') | no next file with comments »