scripts/slave/recipes/chromium_trybot.py - Issue 1212413002: Pass all compile targets to "analyze"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: scripts/slave/recipes/chromium_trybot.py

Issue 1212413002: Pass all compile targets to "analyze" (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master

Patch Set: Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: scripts/slave/recipes/chromium_trybot.py

diff --git a/scripts/slave/recipes/chromium_trybot.py b/scripts/slave/recipes/chromium_trybot.py

index df15dc718f1f7461019dc75c702a359486cf3f7d..401ebfcd83abd9477451e9e510b0739da7c3bfc6 100644

--- a/scripts/slave/recipes/chromium_trybot.py

+++ b/scripts/slave/recipes/chromium_trybot.py

@@ -462,10 +462,13 @@ def _RunStepsInternal(api):

override_bot_type='builder_tester',

override_tests=tests)

+ targets_for_analyze = sorted(set(

+ all_compile_targets(api, tests + tests_including_triggered) +

+ compile_targets))

sky 2015/06/26 15:29:00 Can we add some sort of assertion that we aren't p

Paweł Hajdan Jr. 2015/06/26 15:42:48 Good point. Done. WDYT?

requires_compile, matching_exes, compile_targets = \

api.chromium_tests.analyze(

affected_files,

- all_compile_targets(api, tests + tests_including_triggered),

+ targets_for_analyze,

compile_targets,

'trybot_analyze_config.json')

« no previous file with comments | « no previous file | scripts/slave/recipes/chromium_trybot.expected/analyze_finds_invalid_target.json » ('j') | no next file with comments »