Pass all compile targets to "analyze"

scripts/slave/recipes/chromium_trybot.py

 # Copyright 2013 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 from infra.libs.infra_types import freeze
 
 DEPS = [
   'bot_update',
   'chromium',
   'chromium_android',
@@ skipping 444 matching lines @@
 
   compile_targets, tests_including_triggered = \
       api.chromium_tests.get_compile_targets_and_tests(
           bot_config['mastername'],
           bot_config['buildername'],
           master_dict,
           test_spec,
           override_bot_type='builder_tester',
           override_tests=tests)
 
+  targets_for_analyze = sorted(set(
+      all_compile_targets(api, tests + tests_including_triggered) +
+      compile_targets))

[sky, 2015/06/26 15:29:00]

Can we add some sort of assertion that we aren't passing in all?

[Paweł Hajdan Jr., 2015/06/26 15:42:48]

Good point. Done. WDYT?

   requires_compile, matching_exes, compile_targets = \
       api.chromium_tests.analyze(
           affected_files,
-          all_compile_targets(api, tests + tests_including_triggered),
+          targets_for_analyze,
           compile_targets,
           'trybot_analyze_config.json')
 
   if not requires_compile:
     return
 
   tests = tests_in_compile_targets(api, matching_exes, tests)
   tests_including_triggered = tests_in_compile_targets(
       api, matching_exes, tests_including_triggered)
 
@@ skipping 588 matching lines @@
 
   yield (
     api.test('swarming_paths') +
     api.properties.tryserver(
       mastername='tryserver.chromium.linux',
       buildername='linux_chromium_rel_ng',
       path_config='swarming',
     ) +
     api.platform.name('linux')
   )