Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(240)

Issue 1212373009: Route 'Select All' OS method through RenderWidgetHostDelegate. (Closed)

Created:
5 years, 5 months ago by lgarron
Modified:
5 years, 5 months ago
Reviewers:
dcheng, nasko
CC:
chromium-reviews, creis+watch_chromium.org, danakj+watch_chromium.org, darin-cc_chromium.org, devtools-reviews_chromium.org, jam, jbauman+watch_chromium.org, kalyank, mohsen, nasko+codewatch_chromium.org, nona+watch_chromium.org, penghuang+watch_chromium.org, pfeldman, piman+watch_chromium.org, shuchen+watch_chromium.org, sievers+watch_chromium.org, James Su, yurys, yusukes+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Route 'Select All' OS method through RenderWidgetHostDelegate. This allows Cmd-A / "Select All" to be used on SSL interstitials on OSX. BUG=507416 Committed: https://crrev.com/145aaa8a7762909442a684415333ebce4f65a229 Cr-Commit-Position: refs/heads/master@{#338248}

Patch Set 1 : #

Patch Set 2 : Rename "create and set input text to "create input and set text". #

Patch Set 3 : Add missing overrides. #

Total comments: 2

Patch Set 4 : Move TearDownTestClipboard back to InterstitialPageImplTest.Paste #

Unified diffs Side-by-side diffs Delta from patch set Stats (+69 lines, -15 lines) Patch
M content/browser/frame_host/interstitial_page_impl.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/frame_host/interstitial_page_impl.cc View 1 chunk +10 lines, -0 lines 0 comments Download
M content/browser/frame_host/interstitial_page_impl_browsertest.cc View 1 2 3 7 chunks +43 lines, -11 lines 0 comments Download
M content/browser/frame_host/render_widget_host_view_child_frame_unittest.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/frame_host/render_widget_host_view_guest_unittest.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_delegate.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_aura_unittest.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_mac.mm View 1 chunk +4 lines, -3 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_mac_editcommand_helper_unittest.mm View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_mac_unittest.mm View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/renderer_host/text_input_client_mac_unittest.mm View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/web_contents/web_contents_impl.h View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 20 (8 generated)
lgarron
A followup to https://codereview.chromium.org/1162373002 Includes a new test. :-)
5 years, 5 months ago (2015-07-06 22:04:53 UTC) #2
lgarron
Change reviewer email to Chromium Nasko. ;-)
5 years, 5 months ago (2015-07-06 22:11:44 UTC) #5
nasko
LGTM
5 years, 5 months ago (2015-07-07 13:52:25 UTC) #7
mohsen
https://codereview.chromium.org/1212373009/diff/80001/content/browser/frame_host/interstitial_page_impl_browsertest.cc File content/browser/frame_host/interstitial_page_impl_browsertest.cc (right): https://codereview.chromium.org/1212373009/diff/80001/content/browser/frame_host/interstitial_page_impl_browsertest.cc#newcode400 content/browser/frame_host/interstitial_page_impl_browsertest.cc:400: TearDownTestClipboard(); This line belongs to 'Paste' test.
5 years, 5 months ago (2015-07-07 16:47:32 UTC) #8
lgarron
https://codereview.chromium.org/1212373009/diff/80001/content/browser/frame_host/interstitial_page_impl_browsertest.cc File content/browser/frame_host/interstitial_page_impl_browsertest.cc (right): https://codereview.chromium.org/1212373009/diff/80001/content/browser/frame_host/interstitial_page_impl_browsertest.cc#newcode400 content/browser/frame_host/interstitial_page_impl_browsertest.cc:400: TearDownTestClipboard(); On 2015/07/07 at 16:47:32, mohsen wrote: > This ...
5 years, 5 months ago (2015-07-07 17:46:34 UTC) #9
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1212373009/100001
5 years, 5 months ago (2015-07-10 00:54:48 UTC) #12
lgarron
dcheng@: Nasko's LGTM is sufficient for landing, but you reviewed the CL that initiated routing ...
5 years, 5 months ago (2015-07-10 00:55:21 UTC) #13
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 5 months ago (2015-07-10 02:28:49 UTC) #15
dcheng
lgtm
5 years, 5 months ago (2015-07-10 06:03:52 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1212373009/100001
5 years, 5 months ago (2015-07-10 06:09:13 UTC) #18
commit-bot: I haz the power
Committed patchset #4 (id:100001)
5 years, 5 months ago (2015-07-10 07:40:06 UTC) #19
commit-bot: I haz the power
5 years, 5 months ago (2015-07-10 07:42:17 UTC) #20
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/145aaa8a7762909442a684415333ebce4f65a229
Cr-Commit-Position: refs/heads/master@{#338248}

Powered by Google App Engine
This is Rietveld 408576698