content/browser/renderer_host/render_widget_host_view_mac.mm - Issue 1212373009: Route 'Select All' OS method through RenderWidgetHostDelegate.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/render_widget_host_view_mac.mm

Issue 1212373009: Route 'Select All' OS method through RenderWidgetHostDelegate. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Move TearDownTestClipboard back to InterstitialPageImplTest.Paste Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/renderer_host/render_widget_host_view_aura_unittest.cc ('k') | content/browser/renderer_host/render_widget_host_view_mac_editcommand_helper_unittest.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/renderer_host/render_widget_host_view_mac.mm

diff --git a/content/browser/renderer_host/render_widget_host_view_mac.mm b/content/browser/renderer_host/render_widget_host_view_mac.mm

index 6100e3304855989244af137dd2f149f0e8a3e5af..91c9fd9ef7b41df6f4b459d2b5d7c600ca1a2a05 100644

--- a/content/browser/renderer_host/render_widget_host_view_mac.mm

+++ b/content/browser/renderer_host/render_widget_host_view_mac.mm

@@ -3123,9 +3123,10 @@ extern NSString *NSTextInputReplacementRangeAttributeName;

// menu handler, neither is true.

// Explicitly call SelectAll() here to make sure the renderer returns

// selection results.

- WebContents* web_contents = renderWidgetHostView_->GetWebContents();

- if (web_contents)

- web_contents->SelectAll();

+ content::RenderWidgetHostDelegate* render_widget_host_delegate =

+ renderWidgetHostView_->render_widget_host_->delegate();

+ if (render_widget_host_delegate)

+ render_widget_host_delegate->SelectAll();

}

- (void)startSpeaking:(id)sender {