Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1212373004: Move AppIsolationInfo from chrome to extensions. (Closed)

Created:
5 years, 6 months ago by tfarina
Modified:
5 years, 5 months ago
Reviewers:
Lei Zhang, Devlin
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org, Ken Rockot(use gerrit already), tmdiep
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move AppIsolationInfo from chrome to extensions. This is necessary because HasIsolatedStorage() depends on it, so in order to get HasIsolatedStorage() in extensions as well we need to have AIF in there too. This will help for the tmdiep's TODO in extensions/browser/extension_util.h. BUG=None R=rdevlin.cronin@chromium.org tbr=thestig@chromium.org Committed: https://crrev.com/0bcdf36e3b924ad6810dcdfce66d730befb386e9 Cr-Commit-Position: refs/heads/master@{#336658}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -159 lines) Patch
M chrome/browser/extensions/chrome_content_browser_client_extensions_part.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/extensions/data_deleter.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_garbage_collector.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_special_storage_policy.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_util.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/chrome_common.gypi View 2 chunks +1 line, -3 lines 0 comments Download
M chrome/common/extensions/chrome_manifest_handlers.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/common/extensions/extension_process_policy.cc View 1 chunk +1 line, -1 line 0 comments Download
D chrome/common/extensions/manifest_handlers/app_isolation_info.h View 1 chunk +0 lines, -44 lines 0 comments Download
D chrome/common/extensions/manifest_handlers/app_isolation_info.cc View 1 chunk +0 lines, -98 lines 0 comments Download
M chrome/common/extensions/manifest_tests/extension_manifests_isolatedapp_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/manifest_tests/extension_manifests_platformapp_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
A + extensions/common/manifest_handlers/app_isolation_info.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + extensions/common/manifest_handlers/app_isolation_info.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/extensions.gypi View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
tfarina
As discussed in the email. PTAL.
5 years, 6 months ago (2015-06-27 00:44:31 UTC) #1
Devlin
lgtm
5 years, 5 months ago (2015-06-29 17:18:06 UTC) #2
tfarina
TBRing Lei for chrome_common.gypi.
5 years, 5 months ago (2015-06-29 20:53:27 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1212373004/1
5 years, 5 months ago (2015-06-29 20:56:14 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-06-29 22:19:34 UTC) #7
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/0bcdf36e3b924ad6810dcdfce66d730befb386e9 Cr-Commit-Position: refs/heads/master@{#336658}
5 years, 5 months ago (2015-06-29 22:20:21 UTC) #8
Lei Zhang
5 years, 5 months ago (2015-07-14 00:17:21 UTC) #9
Message was sent while issue was closed. 
On 2015/06/29 20:53:27, tfarina wrote:
> TBRing Lei for chrome_common.gypi.

LGTM

Powered by Google App Engine
This is Rietveld 408576698