Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(699)

Side by Side Diff: chrome/common/extensions/manifest_handlers/app_isolation_info.cc

Issue 1212373004: Move AppIsolationInfo from chrome to extensions. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #include "chrome/common/extensions/manifest_handlers/app_isolation_info.h"
6
7 #include "base/memory/scoped_ptr.h"
8 #include "base/strings/string16.h"
9 #include "base/strings/string_number_conversions.h"
10 #include "base/strings/utf_string_conversions.h"
11 #include "base/values.h"
12 #include "extensions/common/error_utils.h"
13 #include "extensions/common/manifest_constants.h"
14 #include "extensions/common/manifest_handlers/permissions_parser.h"
15 #include "extensions/common/permissions/api_permission_set.h"
16
17 namespace extensions {
18
19 namespace keys = manifest_keys;
20
21 AppIsolationInfo::AppIsolationInfo(bool isolated_storage)
22 : has_isolated_storage(isolated_storage) {
23 }
24
25 AppIsolationInfo::~AppIsolationInfo() {
26 }
27
28 // static
29 bool AppIsolationInfo::HasIsolatedStorage(const Extension* extension) {
30 AppIsolationInfo* info = static_cast<AppIsolationInfo*>(
31 extension->GetManifestData(keys::kIsolation));
32 return info ? info->has_isolated_storage : false;
33 }
34
35 AppIsolationHandler::AppIsolationHandler() {
36 }
37
38 AppIsolationHandler::~AppIsolationHandler() {
39 }
40
41 bool AppIsolationHandler::Parse(Extension* extension, base::string16* error) {
42 // Platform apps always get isolated storage.
43 if (extension->is_platform_app()) {
44 extension->SetManifestData(keys::kIsolation, new AppIsolationInfo(true));
45 return true;
46 }
47
48 // Other apps only get it if it is requested _and_ experimental APIs are
49 // enabled.
50 if (!extension->is_app() ||
51 !PermissionsParser::HasAPIPermission(extension,
52 APIPermission::kExperimental)) {
53 return true;
54 }
55
56 // We should only be parsing if the extension has the key in the manifest,
57 // or is a platform app (which we already handled).
58 DCHECK(extension->manifest()->HasPath(keys::kIsolation));
59
60 const base::ListValue* isolation_list = NULL;
61 if (!extension->manifest()->GetList(keys::kIsolation, &isolation_list)) {
62 *error = base::ASCIIToUTF16(manifest_errors::kInvalidIsolation);
63 return false;
64 }
65
66 bool has_isolated_storage = false;
67 for (size_t i = 0; i < isolation_list->GetSize(); ++i) {
68 std::string isolation_string;
69 if (!isolation_list->GetString(i, &isolation_string)) {
70 *error = ErrorUtils::FormatErrorMessageUTF16(
71 manifest_errors::kInvalidIsolationValue,
72 base::UintToString(i));
73 return false;
74 }
75
76 // Check for isolated storage.
77 if (isolation_string == manifest_values::kIsolatedStorage) {
78 has_isolated_storage = true;
79 } else {
80 DLOG(WARNING) << "Did not recognize isolation type: " << isolation_string;
81 }
82 }
83
84 if (has_isolated_storage)
85 extension->SetManifestData(keys::kIsolation, new AppIsolationInfo(true));
86
87 return true;
88 }
89
90 bool AppIsolationHandler::AlwaysParseForType(Manifest::Type type) const {
91 return type == Manifest::TYPE_PLATFORM_APP;
92 }
93
94 const std::vector<std::string> AppIsolationHandler::Keys() const {
95 return SingleKey(keys::kIsolation);
96 }
97
98 } // namespace extensions
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698