Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1212343011: improve divider appearance in dark mode (Closed)

Created:
5 years, 5 months ago by jackson
Modified:
5 years, 5 months ago
Reviewers:
abarth-chromium
CC:
abarth-chromium, gregsimon, jackson_old, mojo-reviews_chromium.org, qsr+mojo_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : avoid copy pasta #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -7 lines) Patch
M sky/sdk/example/stocks/lib/stock_row.dart View 1 1 chunk +3 lines, -3 lines 0 comments Download
M sky/sdk/lib/theme/theme_data.dart View 1 2 chunks +2 lines, -0 lines 0 comments Download
M sky/sdk/lib/widgets/menu_divider.dart View 1 2 chunks +5 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
abarth-chromium
LGTM https://codereview.chromium.org/1212343011/diff/1/sky/sdk/lib/widgets/menu_divider.dart File sky/sdk/lib/widgets/menu_divider.dart (right): https://codereview.chromium.org/1212343011/diff/1/sky/sdk/lib/widgets/menu_divider.dart#newcode16 sky/sdk/lib/widgets/menu_divider.dart:16: return const Color.fromARGB(31, 255, 255, 255); Do these ...
5 years, 5 months ago (2015-07-07 00:31:35 UTC) #2
jackson
https://codereview.chromium.org/1212343011/diff/1/sky/sdk/lib/widgets/menu_divider.dart File sky/sdk/lib/widgets/menu_divider.dart (right): https://codereview.chromium.org/1212343011/diff/1/sky/sdk/lib/widgets/menu_divider.dart#newcode16 sky/sdk/lib/widgets/menu_divider.dart:16: return const Color.fromARGB(31, 255, 255, 255); On 2015/07/07 00:31:35, ...
5 years, 5 months ago (2015-07-07 00:59:20 UTC) #3
jackson
5 years, 5 months ago (2015-07-07 01:05:20 UTC) #4
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
19c8ce0b919935dab6ce15614370c3b2f3325de6 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698