Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1527)

Unified Diff: sky/sdk/lib/theme/theme_data.dart

Issue 1212343011: improve divider appearance in dark mode (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: avoid copy pasta Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sky/sdk/example/stocks/lib/stock_row.dart ('k') | sky/sdk/lib/widgets/menu_divider.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/sdk/lib/theme/theme_data.dart
diff --git a/sky/sdk/lib/theme/theme_data.dart b/sky/sdk/lib/theme/theme_data.dart
index cfefa334a4f187c5cb21bb053623549de9481e6a..be7652afaba4b15c77df09a3d9f1ad05b4a32d2e 100644
--- a/sky/sdk/lib/theme/theme_data.dart
+++ b/sky/sdk/lib/theme/theme_data.dart
@@ -22,6 +22,7 @@ class ThemeData {
this.primarySwatch = primarySwatch,
canvasColor = brightness == ThemeBrightness.dark ? colors.Grey[850] : colors.Grey[50],
cardColor = brightness == ThemeBrightness.dark ? colors.Grey[800] : colors.White,
+ dividerColor = brightness == ThemeBrightness.dark ? const Color(0x1FFFFFFF) : const Color(0x1F000000),
text = brightness == ThemeBrightness.dark ? typography.white : typography.black {
assert(brightness != null);
@@ -61,6 +62,7 @@ class ThemeData {
final Map<int, Color> primarySwatch;
final Color canvasColor;
final Color cardColor;
+ final Color dividerColor;
final typography.TextTheme text;
Color _primaryColor;
« no previous file with comments | « sky/sdk/example/stocks/lib/stock_row.dart ('k') | sky/sdk/lib/widgets/menu_divider.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698