DevTools: [CSS] migrate setStyleSheetText to promises

DevTools: [CSS] migrate setStyleSheetText to promises

R=pfeldman

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197916

[lushnikov, 2015-06-26 08:03:51]

ptal

[pfeldman, 2015-06-26 09:13:43]

lgtm

https://codereview.chromium.org/1212263002/diff/1/Source/devtools/front_end/b...
File Source/devtools/front_end/bindings/StylesSourceMapping.js (left):

https://codereview.chromium.org/1212263002/diff/1/Source/devtools/front_end/b...
Source/devtools/front_end/bindings/StylesSourceMapping.js:269:
userCallback(error);
If there was one stylesheet, a very common case, we used to preserve the error
message.

https://codereview.chromium.org/1212263002/diff/1/Source/devtools/front_end/b...
File Source/devtools/front_end/bindings/StylesSourceMapping.js (right):

https://codereview.chromium.org/1212263002/diff/1/Source/devtools/front_end/b...
Source/devtools/front_end/bindings/StylesSourceMapping.js:382:
_commitIncrementalEdit: function(finishCallback)
Add fixme to make it a promise?

https://codereview.chromium.org/1212263002/diff/1/Source/devtools/front_end/s...
File Source/devtools/front_end/sdk/CSSStyleModel.js (right):

https://codereview.chromium.org/1212263002/diff/1/Source/devtools/front_end/s...
Source/devtools/front_end/sdk/CSSStyleModel.js:1835:
this._setContentPromise(newText)
Add fixme to remove

[lushnikov, 2015-06-26 12:33:28]

Regarding those "ACK"s - the throttler will run a method and,
in case the method returned promise, wait until promise resolution.

https://codereview.chromium.org/1212263002/diff/1/Source/devtools/front_end/b...
File Source/devtools/front_end/bindings/StylesSourceMapping.js (left):

https://codereview.chromium.org/1212263002/diff/1/Source/devtools/front_end/b...
Source/devtools/front_end/bindings/StylesSourceMapping.js:269:
userCallback(error);
On 2015/06/26 09:13:42, pfeldman wrote:
> If there was one stylesheet, a very common case, we used to preserve the error
> message.

Done.

https://codereview.chromium.org/1212263002/diff/1/Source/devtools/front_end/b...
File Source/devtools/front_end/bindings/StylesSourceMapping.js (right):

https://codereview.chromium.org/1212263002/diff/1/Source/devtools/front_end/b...
Source/devtools/front_end/bindings/StylesSourceMapping.js:382:
_commitIncrementalEdit: function(finishCallback)
On 2015/06/26 09:13:42, pfeldman wrote:
> Add fixme to make it a promise?

Acknowledged.

https://codereview.chromium.org/1212263002/diff/1/Source/devtools/front_end/s...
File Source/devtools/front_end/sdk/CSSStyleModel.js (right):

https://codereview.chromium.org/1212263002/diff/1/Source/devtools/front_end/s...
Source/devtools/front_end/sdk/CSSStyleModel.js:1835:
this._setContentPromise(newText)
On 2015/06/26 09:13:42, pfeldman wrote:
> Add fixme to remove

Acknowledged.

[lushnikov, 2015-06-26 12:33:32]

The CQ bit was checked by lushnikov@chromium.org

[lushnikov, 2015-06-26 12:33:33]

The patchset sent to the CQ was uploaded after l-g-t-m from
pfeldman@chromium.org
Link to the patchset: https://codereview.chromium.org/1212263002/#ps20001
(title: "log error from first stylesheet")

[commit-bot: I haz the power, 2015-06-26 12:33:46]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1212263002/20001

[commit-bot: I haz the power, 2015-06-26 13:57:33]

Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197916