Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(250)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1204393002: DevTools: [CSS] promisify CSSStyleModel fetching methods (Closed)

Created:
5 years, 6 months ago by lushnikov
Modified:
5 years, 6 months ago
Reviewers:
pfeldman
CC:
blink-reviews, caseq+blink_chromium.org, blink-reviews-style_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, kozyatinskiy+blink_chromium.org
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

DevTools: [CSS] promisify CSSStyleModel fetching methods As CSSAgent was promisified, this patch promisifies all the fetching commands from CSSStyleModel, such as: - getComputedStyle - getInlineStyle - getMatchedStyles - getMediaQueries - getPlatformFonts R=pfeldman Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197905

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+79 lines, -123 lines) Patch
M LayoutTests/http/tests/inspector/modify-cross-domain-rule.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/inspector/elements/hide-shortcut.html View 4 chunks +6 lines, -6 lines 0 comments Download
M LayoutTests/inspector/elements/styles-1/add-new-rule-inline-style-csp.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/inspector/elements/styles-1/cached-sync-computed-styles.html View 2 chunks +3 lines, -3 lines 0 comments Download
M LayoutTests/inspector/elements/styles-1/edit-value-inside-property.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/inspector/elements/styles-2/import-pseudoclass-crash.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/inspector/elements/styles-2/multiple-imports-edit-crash.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/inspector/elements/styles-2/property-ui-location.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/inspector/elements/styles-4/styles-formatting.html View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/devtools/front_end/audits/AuditRules.js View 4 chunks +21 lines, -11 lines 0 comments Download
M Source/devtools/front_end/elements/MetricsSidebarPane.js View 2 chunks +8 lines, -4 lines 0 comments Download
M Source/devtools/front_end/elements/PlatformFontsWidget.js View 2 chunks +8 lines, -10 lines 0 comments Download
M Source/devtools/front_end/elements/SharedSidebarModel.js View 1 chunk +1 line, -10 lines 0 comments Download
M Source/devtools/front_end/emulation/MediaQueryInspector.js View 1 chunk +4 lines, -10 lines 2 comments Download
M Source/devtools/front_end/sdk/CSSStyleModel.js View 7 chunks +20 lines, -61 lines 0 comments Download

Depends on Patchset:

Issue 1196193016 Patch 120001

Dependent Patchsets:

Issue 1212263002 Patch 1
Issue 1212263002 Patch 20001

Messages

Total messages: 10 (3 generated)
lushnikov
ptal
5 years, 6 months ago (2015-06-25 18:12:36 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1204393002/1
5 years, 6 months ago (2015-06-25 18:20:07 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 6 months ago (2015-06-25 19:38:07 UTC) #5
pfeldman
lgtm https://codereview.chromium.org/1204393002/diff/1/Source/devtools/front_end/emulation/MediaQueryInspector.js File Source/devtools/front_end/emulation/MediaQueryInspector.js (right): https://codereview.chromium.org/1204393002/diff/1/Source/devtools/front_end/emulation/MediaQueryInspector.js#newcode190 Source/devtools/front_end/emulation/MediaQueryInspector.js:190: .then(finishCallback) then(finishCallback, finishCallback);
5 years, 6 months ago (2015-06-26 09:59:17 UTC) #6
lushnikov
https://codereview.chromium.org/1204393002/diff/1/Source/devtools/front_end/emulation/MediaQueryInspector.js File Source/devtools/front_end/emulation/MediaQueryInspector.js (right): https://codereview.chromium.org/1204393002/diff/1/Source/devtools/front_end/emulation/MediaQueryInspector.js#newcode190 Source/devtools/front_end/emulation/MediaQueryInspector.js:190: .then(finishCallback) The .catch is way more easy to read ...
5 years, 6 months ago (2015-06-26 10:16:26 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1204393002/1
5 years, 6 months ago (2015-06-26 10:57:49 UTC) #9
commit-bot: I haz the power
5 years, 6 months ago (2015-06-26 11:00:58 UTC) #10
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197905

Powered by Google App Engine
This is Rietveld 408576698