Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(388)

Issue 1212253009: Debugger: clear ICs on activating step-in to correctly flood accessor pairs. (Closed)

Created:
5 years, 5 months ago by Yang
Modified:
5 years, 5 months ago
Reviewers:
mvstanton
CC:
v8-dev, Yang
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Debugger: clear ICs on activating step-in to correctly flood accessor pairs. If we compile handlers to call accessors, Debug::HandleStepIn won't get called. Therefore we need to clear ICs each time. This has not been necessary before because we used to patch ICs for breaking, and restored them with cleared ICs. This is no longer the case. We do not use ICs for breaking anymore, so they are not implicitly cleared any longer. R=mvstanton@chromium.org BUG=v8:4269 LOG=N Committed: https://crrev.com/c1b5d1743903c12880cbba3afaac9da1781d0a9f Cr-Commit-Position: refs/heads/master@{#29518}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+81 lines, -33 lines) Patch
M src/debug.h View 2 chunks +2 lines, -3 lines 0 comments Download
M src/debug.cc View 4 chunks +15 lines, -18 lines 0 comments Download
M src/objects.cc View 2 chunks +2 lines, -6 lines 0 comments Download
M src/runtime/runtime-classes.cc View 1 chunk +1 line, -3 lines 0 comments Download
M src/runtime/runtime-debug.cc View 1 chunk +11 lines, -0 lines 0 comments Download
M src/runtime/runtime-object.cc View 1 chunk +1 line, -3 lines 0 comments Download
A test/mjsunit/debug-stepin-accessor-ic.js View 1 chunk +49 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
Yang
5 years, 5 months ago (2015-07-07 12:11:03 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1212253009/1
5 years, 5 months ago (2015-07-07 12:11:17 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 5 months ago (2015-07-07 12:35:51 UTC) #5
mvstanton
lgtm
5 years, 5 months ago (2015-07-07 13:50:45 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1212253009/1
5 years, 5 months ago (2015-07-07 13:51:18 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-07 13:56:36 UTC) #9
commit-bot: I haz the power
5 years, 5 months ago (2015-07-07 13:57:25 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c1b5d1743903c12880cbba3afaac9da1781d0a9f
Cr-Commit-Position: refs/heads/master@{#29518}

Powered by Google App Engine
This is Rietveld 408576698