src/runtime/runtime-object.cc - Issue 1212253009: Debugger: clear ICs on activating step-in to correctly flood accessor pairs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/runtime/runtime-object.cc

Issue 1212253009: Debugger: clear ICs on activating step-in to correctly flood accessor pairs. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/runtime/runtime-object.cc

diff --git a/src/runtime/runtime-object.cc b/src/runtime/runtime-object.cc

index b3ac1864ba822a6a91ca7bd5a112f1b2acbf8e2d..da1ec4977be36f1965f86e60cbfd5e08c8e02fdd 100644

--- a/src/runtime/runtime-object.cc

+++ b/src/runtime/runtime-object.cc

@@ -1072,9 +1072,7 @@ static Object* Runtime_NewObjectHelper(Isolate* isolate,

Debug* debug = isolate->debug();

// Handle stepping into constructors if step into is active.

- if (debug->StepInActive()) {

- debug->HandleStepIn(function, Handle<Object>::null(), 0, true);

- }

+ if (debug->StepInActive()) debug->HandleStepIn(function, true);

if (function->has_initial_map()) {

if (function->initial_map()->instance_type() == JS_FUNCTION_TYPE) {

« no previous file with comments | « src/runtime/runtime-debug.cc ('k') | test/mjsunit/debug-stepin-accessor-ic.js » ('j') | no next file with comments »