Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Issue 121173005: Work on Android GN build. (Closed)

Created:
6 years, 11 months ago by brettw
Modified:
6 years, 11 months ago
Reviewers:
cjhopman, Torne
CC:
chromium-reviews
Visibility:
Public.

Description

Work on Android GN build. Adds arm version and some android configuration build flags. This adds most of the logic from common.gypi to the Android GN build. This is currently missing the crtbegin/end stuff and won't actually make real Android builds. The logic in this patch is just the initial conversion that will require testing and several more passes of fixes. R=torne@chromium.org, torne Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=243681

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Patch Set 6 : #

Patch Set 7 : A few minor fixes #

Patch Set 8 : #

Patch Set 9 : #

Patch Set 10 : Debug print #

Patch Set 11 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+388 lines, -121 lines) Patch
A build/config/android/config.gni View 1 2 3 4 5 6 7 8 9 10 1 chunk +60 lines, -0 lines 0 comments Download
A build/config/arm.gni View 1 1 chunk +9 lines, -0 lines 0 comments Download
M build/config/compiler/BUILD.gn View 1 2 3 4 5 6 10 chunks +287 lines, -108 lines 0 comments Download
M build/config/linux/BUILD.gn View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M build/config/linux/sysroot.gni View 1 2 3 4 5 6 7 8 1 chunk +18 lines, -3 lines 0 comments Download
M build/gyp_chromium View 1 2 3 4 5 6 7 2 chunks +9 lines, -2 lines 0 comments Download
M build/toolchain/android/BUILD.gn View 1 2 3 1 chunk +4 lines, -7 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
brettw
6 years, 11 months ago (2014-01-02 21:44:33 UTC) #1
Torne
I haven't looked at this in detail yet, but a question about crtbegin/end.. when you ...
6 years, 11 months ago (2014-01-03 16:14:37 UTC) #2
brettw
On 2014/01/03 16:14:37, Torne wrote: > I haven't looked at this in detail yet, but ...
6 years, 11 months ago (2014-01-03 18:39:46 UTC) #3
Torne
Still haven't had a chance to look at this in detail, but +cjhopman who I ...
6 years, 11 months ago (2014-01-06 16:13:13 UTC) #4
brettw
6 years, 11 months ago (2014-01-08 22:47:49 UTC) #5
Message was sent while issue was closed.
Committed patchset #11 manually as r243681 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698