Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3027)

Unified Diff: build/gyp_chromium

Issue 121173005: Work on Android GN build. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/config/linux/sysroot.gni ('k') | build/toolchain/android/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/gyp_chromium
diff --git a/build/gyp_chromium b/build/gyp_chromium
index 4eafdd541ed71cb9cd1caa434105d81bf3daa6a8..b3db688f695a071927df0ed2e2b3c9cdd9a8d2f7 100755
--- a/build/gyp_chromium
+++ b/build/gyp_chromium
@@ -131,6 +131,7 @@ def GetArgsStringForGN(supplemental_files):
# These tuples of (key, value, gn_arg_string) use the gn_arg_string for
# gn when the key is set to the given value in the GYP arguments.
remap_cases = [
+ ('android_webview_build', '1', 'is_android_webview_build=true'),
('branding', 'Chrome', 'is_chrome_branded=true'),
('buildtype', 'Official', 'is_official_build=true'),
('component', 'shared_library', 'is_component_build=true'),
@@ -153,11 +154,17 @@ def GetArgsStringForGN(supplemental_files):
if i[0] in vars_dict and vars_dict[i[0]] == i[1]:
gn_args += ' ' + i[2]
- # These string arguments get passed directly.
- for v in ['windows_sdk_path']:
+ # These string arguments get passed directly as GN strings.
+ for v in ['android_src', 'windows_sdk_path']:
if v in vars_dict:
gn_args += ' ' + v + '=' + EscapeStringForGN(vars_dict[v])
+ # These arguments get passed directly as integers (avoiding the quoting and
+ # escaping of the string ones above).
+ for v in ['arm_version']:
+ if v in vars_dict:
+ gn_args += ' %s=%s' % (v, vars_dict[v])
+
# Set the GYP flag so BUILD files know they're being invoked in GYP mode.
gn_args += ' is_gyp=true'
return gn_args.strip()
« no previous file with comments | « build/config/linux/sysroot.gni ('k') | build/toolchain/android/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698