Source/core/svg/SVGAltGlyphElement.cpp - Issue 121173004: Make calls to AtomicString(const String&) explicit in svg/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/svg/SVGAltGlyphElement.cpp

Issue 121173004: Make calls to AtomicString(const String&) explicit in svg/ (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Take feedback into consideration Created 6 years, 12 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/svg/SVGAltGlyphElement.cpp

diff --git a/Source/core/svg/SVGAltGlyphElement.cpp b/Source/core/svg/SVGAltGlyphElement.cpp

index b170919f5b998332e42cbc7f100578579c56d358..3de1575fbf668646d70dbc1ba455b1f9d0eb9df8 100644

--- a/Source/core/svg/SVGAltGlyphElement.cpp

+++ b/Source/core/svg/SVGAltGlyphElement.cpp

@@ -86,9 +86,9 @@ RenderObject* SVGAltGlyphElement::createRenderer(RenderStyle*)

return new RenderSVGTSpan(this);

}

-bool SVGAltGlyphElement::hasValidGlyphElements(Vector<String>& glyphNames) const

+bool SVGAltGlyphElement::hasValidGlyphElements(Vector<AtomicString>& glyphNames) const

{

- String target;

+ AtomicString target;

Element* element = targetElementFromIRIString(getAttribute(XLinkNames::hrefAttr), document(), &target);

if (!element)

return false;

« no previous file with comments | « Source/core/svg/SVGAltGlyphElement.h ('k') | Source/core/svg/SVGAltGlyphItemElement.h » ('j') | no next file with comments »