Source/core/rendering/svg/RenderSVGResourceFilter.cpp - Issue 121173004: Make calls to AtomicString(const String&) explicit in svg/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/rendering/svg/RenderSVGResourceFilter.cpp

Issue 121173004: Make calls to AtomicString(const String&) explicit in svg/ (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Take feedback into consideration Created 6 years, 12 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/rendering/svg/RenderSVGResourceFilter.cpp

diff --git a/Source/core/rendering/svg/RenderSVGResourceFilter.cpp b/Source/core/rendering/svg/RenderSVGResourceFilter.cpp

index 840c563c4c28812a90ff38257529c6f9857b6453..ece0a521beaac3e573848a11f92848720b6ffeac 100644

--- a/Source/core/rendering/svg/RenderSVGResourceFilter.cpp

+++ b/Source/core/rendering/svg/RenderSVGResourceFilter.cpp

@@ -96,7 +96,7 @@ PassRefPtr<SVGFilterBuilder> RenderSVGResourceFilter::buildPrimitives(SVGFilter*

effect->setEffectBoundaries(SVGLengthContext::resolveRectangle<SVGFilterPrimitiveStandardAttributes>(effectElement, filterElement->primitiveUnitsCurrentValue(), targetBoundingBox));

effect->setOperatingColorSpace(

effectElement->renderer()->style()->svgStyle()->colorInterpolationFilters() == CI_LINEARRGB ? ColorSpaceLinearRGB : ColorSpaceDeviceRGB);

- builder->add(effectElement->resultCurrentValue(), effect);

+ builder->add(AtomicString(effectElement->resultCurrentValue()), effect);

}

return builder.release();

}

« no previous file with comments | « Source/core/rendering/svg/ReferenceFilterBuilder.cpp ('k') | Source/core/rendering/svg/SVGResources.cpp » ('j') | no next file with comments »