Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 1211623003: Use --icf=all for Linux64 too. (Closed)

Created:
5 years, 6 months ago by Nico
Modified:
5 years, 6 months ago
Reviewers:
Lei Zhang
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use --icf=all for Linux64 too. It's inconclusive if this caused a cold start performance regression -- graphs went up when this first landed, but they didn't recover after the revert. And on a zoomed-out scale, the graphs didn't go up much, so maybe that was just noise. Relanding to see if it has an effect again (if so, I will revert this again). BUG=492809, 492177 TBR=thestig@chromium.org Committed: https://crrev.com/eca59926d104516f65793063c6a5c04855a8a3fd Cr-Commit-Position: refs/heads/master@{#335985}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -24 lines) Patch
M build/common.gypi View 3 chunks +4 lines, -13 lines 0 comments Download
M build/config/compiler/BUILD.gn View 1 chunk +1 line, -11 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Nico
5 years, 6 months ago (2015-06-24 18:21:00 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1211623003/1
5 years, 6 months ago (2015-06-24 18:22:17 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-24 20:08:41 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/eca59926d104516f65793063c6a5c04855a8a3fd Cr-Commit-Position: refs/heads/master@{#335985}
5 years, 6 months ago (2015-06-24 20:09:47 UTC) #5
Lei Zhang
5 years, 6 months ago (2015-06-24 20:43:17 UTC) #6
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698