Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(954)

Unified Diff: build/config/compiler/BUILD.gn

Issue 1211623003: Use --icf=all for Linux64 too. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/common.gypi ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/config/compiler/BUILD.gn
diff --git a/build/config/compiler/BUILD.gn b/build/config/compiler/BUILD.gn
index 7a22b99545953704009a6905e4c76ea893c2e332..f5aa86ca1e239ec8035cd0fc933f8b8c8031aff2 100644
--- a/build/config/compiler/BUILD.gn
+++ b/build/config/compiler/BUILD.gn
@@ -467,17 +467,7 @@ config("compiler") {
if (!is_asan && !is_msan && !is_lsan && !is_tsan) {
# TODO(brettw) common.gypi has this only for target toolset.
- if (current_cpu == "x64") {
- # --icf=safe disables much more folding on x86_64 than elsewhere, see
- # http://crbug.com/492177. Turning it on saves over 12 MB of binary
- # size, but it seems to regress cold startup time by over a second
- # (see http://crbug.com/492809).
- # TODO(thakis): Check if disabling ICF would inmprove android cold start
- # times by several seconds too.
- ldflags += [ "-Wl,--icf=safe" ]
- } else {
- ldflags += [ "-Wl,--icf=all" ]
- }
+ ldflags += [ "-Wl,--icf=all" ]
}
# TODO(thestig): Make this flag work with GN.
« no previous file with comments | « build/common.gypi ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698